Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock Mollie API requests in RSpec when Travis job is triggered by PR #26

Open
vernondegoede opened this issue Sep 27, 2018 · 0 comments
Open

Mock Mollie API requests in RSpec when Travis job is triggered by PR #26

vernondegoede opened this issue Sep 27, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@vernondegoede
Copy link
Contributor

We should Mock the Mollie API calls when the Travis job is triggered by a PR by an external maintainer. Since our API key is encrypted, integrations tests will always fail because the encrypted environment variables are not available from external sources (PR's initiated by external collaborators).

More information: https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
@vernondegoede vernondegoede added the enhancement New feature or request label May 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vernondegoede