-
Notifications
You must be signed in to change notification settings - Fork 858
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test262 properties outdated #1764
Comments
Yes, re-running and re-committing is the right fix, with a simple PR.
However, it might be worth looking at that PR -- there is a lot of complex
logic in there for calculating how to report on the test failures in the
four remaining test modes (non strict, strict, interpreted, and optimized)
and perhaps I missed some logic -- I think that both cases are the same,
but previously we must have consolidated them into one "non-strict" case
and now we don't.
|
Can we close this? |
I think so. FWIW, for me, on three different OSes, even forcing Java 11 for the whole build, I can't use "updateTest262properties" without seeing a whole bunch of changes to that file that aren't relevant, so I made my last update manually. I wonder if anyone else has the same problem or if I'm doing something wrong. |
Works for me with java 11. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I've noticed that the test262.properties file is outdated today. The diffs are surprising though:
So I am not sure if just rerunning and commiting is the right fix. I guess this might be related to the optimization level of #1754 ?
The text was updated successfully, but these errors were encountered: