Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test262 properties outdated #1764

Open
andreabergia opened this issue Dec 20, 2024 · 4 comments
Open

Test262 properties outdated #1764

andreabergia opened this issue Dec 20, 2024 · 4 comments

Comments

@andreabergia
Copy link
Contributor

I've noticed that the test262.properties file is outdated today. The diffs are surprising though:

-     from/calling-from-valid-1-noStrict.js non-strict Spec pretty clearly says this should be undefined
+     from/calling-from-valid-1-noStrict.js {compiled-non-strict,interpreted-non-strict} Spec pretty clearly says this should be undefined

So I am not sure if just rerunning and commiting is the right fix. I guess this might be related to the optimization level of #1754 ?

@gbrail
Copy link
Collaborator

gbrail commented Dec 20, 2024 via email

@rbri
Copy link
Collaborator

rbri commented Dec 24, 2024

Can we close this?

@gbrail
Copy link
Collaborator

gbrail commented Dec 24, 2024

I think so.

FWIW, for me, on three different OSes, even forcing Java 11 for the whole build, I can't use "updateTest262properties" without seeing a whole bunch of changes to that file that aren't relevant, so I made my last update manually. I wonder if anyone else has the same problem or if I'm doing something wrong.

@rbri
Copy link
Collaborator

rbri commented Dec 24, 2024

Works for me with java 11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants