Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clang-format fails on MSYS #5097

Open
1 task done
akihikodaki opened this issue Dec 26, 2024 · 3 comments
Open
1 task done

clang-format fails on MSYS #5097

akihikodaki opened this issue Dec 26, 2024 · 3 comments
Labels

Comments

@akihikodaki
Copy link

Description / Steps to reproduce the issue

  1. pacman -S clang git
  2. Open "MSYS2 MSYS"
  3. git clone https://github.com/virtio-win/kvm-guest-drivers-windows
  4. cd kvm-guest-drivers-windows
  5. clang-format Balloon/app/device.cpp

Expected behavior

Outputs formatted source code. For your information, mingw-w64-x86_64-clang works fine.

Actual behavior

Outputs the following:

YAML:5:3: error: unexpected scalar
  Enabled:         true
  ^
YAML:5:3: error: invalid boolean
  Enabled:         true
  ^
Error reading /c/Users/me/source/repos/kvm-guest-drivers-windows/.clang-format: Invalid argument

Verification

Windows Version

MSYS_NT-10.0-22631

Are you willing to submit a PR?

No

@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

Does the required feature depend on clang/llvm version? Because the msys clang is too older than mingw clang https://packages.msys2.org/search?q=clang

@akihikodaki
Copy link
Author

Does the required feature depend on clang/llvm version? Because the msys clang is too older than mingw clang https://packages.msys2.org/search?q=clang

Yes. The offending one is AlignConsecutiveMacros. It used to be a bool scalar value, but it is now an object that includes Enabled and other properties.

@Biswa96
Copy link
Member

Biswa96 commented Dec 26, 2024

I am not sure if msys clang will be updated soon. It is only for bootstrapping mingw clang toolchain, IIRC.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants