Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

srcinfo-cache: detect changes in sourced scripts #4

Open
lazka opened this issue Oct 17, 2023 · 3 comments
Open

srcinfo-cache: detect changes in sourced scripts #4

lazka opened this issue Oct 17, 2023 · 3 comments

Comments

@lazka
Copy link
Member

lazka commented Oct 17, 2023

We have some PKGBUILD files which source some shared scripts like https://github.com/msys2/MINGW-packages/tree/master/mingw-w64-PKGBUILD-common

We currently don't detect changes to those scripts.

Something like this should work:

$ bash -cx "source PKGBUILD" 2>&1 | sed -n 's/^+* \(source\|\.\) //p'
PKGBUILD
./../mingw-w64-PKGBUILD-common/kde-frameworks5
@Biswa96
Copy link
Member

Biswa96 commented Oct 17, 2023

Should we stop using those PKGBUILD-common files? Every KDE PKGBUILD file uses

source "$(dirname ${BASH_SOURCE[0]})"/../mingw-w64-PKGBUILD-common/kde-frameworks5

However, it appears to deviate from standard practice. May I suggest to use PKGBUILD templates when we migrate from qt5 to qt6?

@lazka
Copy link
Member Author

lazka commented Oct 17, 2023

I'm not sure. I would say don't let this issue influence your decision, since it can easily be solved as I wrote above.

@Biswa96
Copy link
Member

Biswa96 commented Oct 17, 2023

Not an influence. I was planning to do that but I didn't find enough reason to do so. All the KDE PKGBUILDs looks ugly with those random functions from PKGBUILD-common 😄

Also the plan includes migrating to kf6/qt6 in future smoothly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants