Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Slider] Indicator width/height are rounded too soon #1216

Open
mj12albert opened this issue Dec 23, 2024 · 2 comments · May be fixed by #1219
Open

[Slider] Indicator width/height are rounded too soon #1216

mj12albert opened this issue Dec 23, 2024 · 2 comments · May be fixed by #1219
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!

Comments

@mj12albert
Copy link
Member

While the value needs to be rounded to the step, the percentage width/height of the indicator does not need to be rounded in the dragging state. If un-rounded, drag operations should be a bit smoother.
@mj12albert mj12albert added component: slider This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Dec 23, 2024
@onehanddev
Copy link
Contributor

@mj12albert Can I pick this up ?

@mj12albert mj12albert linked a pull request Dec 24, 2024 that will close this issue
Draft
1 task
@mj12albert
Copy link
Member Author

Thanks @onehanddev I've already gotten started with this ~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/slider-indicator-size-rounding mj12albert/base-ui
2 participants
@mj12albert @onehanddev