Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[figma] Properties in <TextField> #351

Open
smith558 opened this issue May 31, 2024 · 6 comments
Open

[figma] Properties in <TextField> #351

smith558 opened this issue May 31, 2024 · 6 comments
Assignees
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! figma

Comments

@smith558
Copy link

smith558 commented May 31, 2024

Steps to reproduce

Kooha-2024-05-31-17-08-49.webm

Current behavior

Has Value incorrectly linked with Label. No property for Has Label.

The issue is only with the Outlined variant. The issue is disappearing Label property, when it should not, watch the attached video.

Expected behavior

No response

Context

No response

Your environment

Software Version
Design file version Material UI - v5.16.0
Design tool Figma
etc.
@smith558 smith558 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 31, 2024
@adrianmanea
Copy link
Collaborator

adrianmanea commented May 31, 2024

It is actually correct—TextField without Value only shows the label.

@adrianmanea adrianmanea removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label May 31, 2024
@smith558
Copy link
Author

It is actually correct—TextField without Value only shows the label.

But once this property is set the Label input field disappears in Figma, it's currently set up in such a way. So it just stays "Label". It's not configured right for sure.

@adrianmanea
Copy link
Collaborator

adrianmanea commented May 31, 2024

I still don't understand what's the issue and is the first time we're hearing it. What's your use case?

No value given by the user:
Screenshot 2024-05-31 at 19 01 14

With value:
Screenshot 2024-05-31 at 19 01 22

@smith558
Copy link
Author

The issue is only with the Outlined variant. The issue is disappearing Label property, when it should not, watch the video below.
Kooha-2024-05-31-17-08-49.webm

@smith558 smith558 changed the title [figma] Incorrect property link in <TextField> [figma] Properties in <TextField> May 31, 2024
@smith558
Copy link
Author

smith558 commented May 31, 2024

@adrianmanea Sorry, I clarified it now. Please see the updated description and new video.

@adrianmanea
Copy link
Collaborator

Thank you for reporting this! I think I understand now, the Label is confused with the Value and it doesn't keep the overwrites.

@zannager zannager added the figma label Jun 3, 2024
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! labels Dec 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: text field This is the name of the generic UI component, not the React module! figma
Projects
None yet
Development

No branches or pull requests

4 participants