Static OSX Build?

[ifrisbie]

[ 97%] Linking CXX executable Mumble.app/Contents/MacOS/Mumble
Undefined symbols for architecture x86_64:
  "qt_static_plugin_QSQLiteDriverPlugin()", referenced from:
      __GLOBAL__sub_I_mumbleApp_plugin_import.cpp in mumbleApp_plugin_import.cpp.o
  "qt_static_plugin_QSvgIconPlugin()", referenced from:
      __GLOBAL__sub_I_mumbleApp_plugin_import.cpp in mumbleApp_plugin_import.cpp.o
  "qt_static_plugin_QSvgPlugin()", referenced from:
      __GLOBAL__sub_I_mumbleApp_plugin_import.cpp in mumbleApp_plugin_import.cpp.o
ld: symbol(s) not found for architecture x86_64

If I build on OSX with static=ON for a mac build I get these undefined symbols. Anyone have any thoughts as to what is missing that I need to include? Are these dynamic libraries that do not have static versions? Is static even possible on OSX?

[davidebeatrici]

Official releases are static, however they are built in a vcpkg environment.

See https://github.com/mumble-voip/mumble/blob/master/docs/dev/build-instructions/build_static.md.

[Krzmbrzl]

There wasn't a very recent update to mumble related to SSL was there?

I don't think so, no.

I have noticed that for OSX builds the /usr/local/include path is baked in before all others (not sure where this is happening)

Maybe by adding Qt it also adds this OpenSSL path?

[ifrisbie]

ok - well, OpenSSL officially removed the X509_get_notBefore/notAfter methods in the first 1.1.1 release (not deprecated, removed) so mumble can actually only be built against 1.1.0. Those functions were replaced with mutable versions (X509_getm_notBefore/After). There were other removed deprecations that affect the Crypt.cpp file as well. I think mumble has just been the victim of library confusion. Not sure yet why my windows build against 1.1.1 worked, but probably a similar deal - it was finding a 1.1.0 version somewhere before the 1.1.1 version included in your vcpkg. But if you look at the libcrypto.a file included you'll see that those function symbols are not there. So mumble currently remains stuck at 1.1.0 so far as I can tell. But I did change a couple of things that will remedy:

In src/CMakeLists add this as the first include of the shared target:

get_target_property(MUMBLE_SSL_DIR OpenSSL::OpenSSL INTERFACE_INCLUDE_DIRECTORIES)
target_include_directories(shared SYSTEM BEFORE
    PUBLIC
        ${MUMBLE_SSL_DIR})

In src/mumble/CMakeLists add it also as the first include of the mumble target:

get_target_property(MUMBLE_SSL_DIR OpenSSL::OpenSSL INTERFACE_INCLUDE_DIRECTORIES)
target_include_directories(shared SYSTEM BEFORE
    PUBLIC
        ${MUMBLE_SSL_DIR})

In src/SelfSignedCertificate.cpp replace this in the SelfSignedCertificate::generate method:

#if OPENSSL_VERSION_NUMBER >= 0x10100000L
    notBefore = X509_getm_notBefore(x509);
#else
    notBefore = X509_get_notBefore(x509);
#endif
    if (!notBefore) {
        ok = false;
        goto out;
    }
    if (!X509_gmtime_adj(notBefore, 0)) {
        ok = false;
        goto out;
    }

#if OPENSSL_VERSION_NUMBER >= 0x10100000L
    notAfter = X509_getm_notAfter(x509);
#else
    notAfter = X509_get_notAfter(x509);
#endif

This allows me to build with 1.1.1a or later without the missing symbols (the Cert.o missing symbols gets resolved simply by having it use the correct header files and didn't require a code change).

[Krzmbrzl]

I hat it when libraries do that... 😞
This means that we now have to do some preprocessor magic to allow the new and the old style 🙄

@ifrisbie Since you seem to know your way around OpenSSL, would you mind creating a PR fixing this issue? :)

[ifrisbie]

Sure, I can add that to my list once I verify everything on my end is functioning properly (might be a while). I amended my comment above to include specific changes I made to get it building properly but certainly I can pull a fresh mumble at some point and make those changes and submit a PR.

[Krzmbrzl]

Okay thank you! 👍
I guess we can wait until you come around creating the PR :)