Question about vcpkg installations and looking for good "first contribution"

[Skewjo]

Hello Mumble team!

(I'm on Windows)

I've used vcpkg a few times for a statically generated (32-bit) program of my own, so I'm hoping this won't be too tough to get started. I'm pasted all of the following into a Powershell script:

.\vcpkg install qt5-base --triplet x64-windows-static-md
.\vcpkg install qt5-svg --triplet x64-windows-static-md
.\vcpkg install qt5-tools --triplet x64-windows-static-md
.\vcpkg install grpc --triplet x64-windows-static-md
.\vcpkg install boost-accumulators --triplet x64-windows-static-md
.\vcpkg install opus --triplet x64-windows-static-md
.\vcpkg install poco --triplet x64-windows-static-md
.\vcpkg install libvorbis --triplet x64-windows-static-md
.\vcpkg install libogg --triplet x64-windows-static-md
.\vcpkg install libflac --triplet x64-windows-static-md
.\vcpkg install libsndfile --triplet x64-windows-static-md
.\vcpkg install libmariadb --triplet x64-windows-static-md
.\vcpkg install zlib --triplet x64-windows-static-md

...but it seems to be stalling quite a bit and I can't tell if it's frozen. I think it's only made it to qt5-tools. Is this a common issue?

Also, I was looking through some of the good first time issues, and it seems that everything has already been "claimed" (now whether or not these people follow-up is up in the air). Are there any good and easy unclaimed issues available for my first contribution?

[Krzmbrzl]

...but it seems to be stalling quite a bit and I can't tell if it's frozen. I think it's only made it to qt5-tools. Is this a common issue?

Qt does take quite a while to build, so it could very well be that it simply needs some time. You can have a look at the CPU and network usage when this happens. One of them should be up.
I also experienced that on Windows I had to click into the shell and hit return every now and then for it to continue. No idea why though 🤷

Also, I was looking through some of the good first time issues, and it seems that everything has already been "claimed" (now whether or not these people follow-up is up in the air). Are there any good and easy unclaimed issues available for my first contribution?

Depending on what you are interested in and what kind of background experience you already have, you could look at one of the following issues:

• Feature Request: Please make Client remember the Avatar #4735
• Option to auto-mute when another person is recording #4591
• Command line option to disable jack auto connect #4132
• Automatically temporarily disable user join/left sounds when users count in channel exceed a certain amount #2556 (I am sure @davidebeatrici doesn't mind if someone else picked up the work)
• Feature request: "Hold Time" default value #2453

[davidebeatrici]

I don't mind at all.

[Skewjo]

@Krzmbrzl, yes it looks like I just wasn't being patient enough with vcpkg. Left to grab lunch, came back, and it was done.
Just need to finish going through the build set-up and I'll take a look at the issues you posted. Thanks!

[Skewjo]

So you added it in Qt Designer, recompiled everything but it is not showing up?

QT Designer isn't just another name for those xml-like ".ui" files is it? <.<
IDK why, but I thought I could just add the code their and it would generate the items.

[Krzmbrzl]

QT Designer isn't just another name for those xml-like ".ui" files is it?

No it's not :D
It's an application created for editing these *.ui files (see https://doc.qt.io/qt-5/qtdesigner-manual.html)

IDK why, but I thought I could just add the code their and it would generate the items.

Well in theory that works as well, but you have to know and understand the format they are using. It's much easier if you just use Qt Designer (it's free) to edit the UI stuff in a (almost) WYSIWYG manner.

[Skewjo]

Holy cow, this has been a nightmare lol
I don't know if it will be welcome or not, but I may end up adding some more detailed documentation (with screenshots for dummies like me) to your build/IDE docs.

In the interest of fully understanding the different environments and builds, I've now successfully built Mumble through the x64 command line, Visual Studio, and QT Creator.

It turns out that I have(at least somewhat) correctly created the elements. They show up in QT designer, but weren't showing up in my final build for some reason.

Edit: Omg, nvm. I "rebuilt" it, but once again forgot the second part of the "dance". Sheesh.

[Skewjo]

@Krzmbrzl
Ok, I've created a PR, and after an absolutely ridiculous amount of trial and error, I was able to get my commits prettified.
#4808

Not sure how I need to snag a count of the current users on the server though.

[Krzmbrzl]

Let's continue the discussion in the PR.
The user count can be obtained by the size of the map of all users that is stored as a static member in the ClientUser class