Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staves with different numbers of lines / placement of symbols w.r.t. staff lines #23

Open
reinierdevalk opened this issue Apr 15, 2021 · 14 comments
Labels
need clarification Decide how this can be represented in MEI need MEI customization Write the MEI customization to enable this

Comments

@reinierdevalk
Copy link
Contributor

Staves can have fewer (or more?) than six lines.

Example:

phalese-1547_7-no_21.png
phalese-1547_7-no_21

@reinierdevalk reinierdevalk added the need MEI customization Write the MEI customization to enable this label Apr 15, 2021
@reinierdevalk reinierdevalk changed the title Enable staff with different numbers of lines Enable staves with different numbers of lines Apr 15, 2021
@DILewis
Copy link
Contributor

DILewis commented Apr 15, 2021

I think we have this already in our spec as <staffdef lines="5"... but I don't know if we can say that symbols go on lines or spaces (and which space)

@reinierdevalk
Copy link
Contributor Author

@DILewis Ah, you're right. Should I change this issue's title into 'Enable placing symbols on or between staff lines'?

@lpugin
Copy link
Member

lpugin commented Apr 16, 2021

If I understand correctly, this means that @tab.course in note can be smaller or greater than values indicated in staffDef. So we should allow <note tab.course="0"> (or even <note tab.course="-1">?) for notes below the course / staff lines. Does it make sense?

@DILewis
Copy link
Contributor

DILewis commented Apr 16, 2021

@lpugin Not quite. The semantics are constant here, it's just the placement of the symbols – some put put symbols on the lines as if the line is an instrumental course being stopped. Others put the symbol between lines so they're easier to read. If you've got 6 lines, you've got 7 spaces, so there's a choice whether to put the first course above or below the first line.
Does that make sense? Reinier probably has examples to hand.

@lpugin
Copy link
Member

lpugin commented Apr 16, 2021

Alternatively, we could make some lines invisible. I think this could be indicated in the staffDef/tuning. Something like:

<staffDef lines="6">
  <tuning>
    <course n="1" visible="false"/>
  </tuning>
</staffDef>

However, setting visual parameter in tuning looks pretty wrong, so maybe this should go elsewhere in staffDef. I don't think we have in CNM a way to make one specific staff line invisible.

@reinierdevalk
Copy link
Contributor Author

reinierdevalk commented Apr 16, 2021

I think we should still use the actual course for those notes. Let's say we have a five-line staff, and a note on the sixth course (as in the example in the issue). Then that note should still have tab.course='6', but it might get a ledger staff line.

@lpugin
Copy link
Member

lpugin commented Apr 16, 2021

OK. I was looking at that particular part:
image

@reinierdevalk
Copy link
Contributor Author

reinierdevalk commented Apr 16, 2021

@lpugin Yes, that's how I understood you. David is talking about something else: whether the symbols are 'through' the lines (as in your example) or on top of them.

@DILewis
Copy link
Contributor

DILewis commented Apr 16, 2021

Sorry, I wasn't thinking about the 5-line staff leger line issue when I replied. Not paying enough attention.

@reinierdevalk
Copy link
Contributor Author

reinierdevalk commented Apr 16, 2021

Should the d on the 6th course in Laurent's example above be treated similar to a note on the 7th, 8th, etc. course, for which there will never be a staff line? EDIT: I mean the diapasons.

@reinierdevalk
Copy link
Contributor Author

reinierdevalk commented Apr 16, 2021

It looks like specifying in the StaffDef whether the symbols are rendered on top of or through the staff lines solves that issue, doesn't it? @lpugin an example of symbols on top of the staff line is this one (notice that there is no ledger line for the 6th-course symbols):

Screenshot 2021-04-16 at 12 20 31

@reinierdevalk reinierdevalk changed the title Enable staves with different numbers of lines Staves with different numbers of lines / placement of symbols w.r.t. staff lines Apr 16, 2021
@lpugin lpugin added the need clarification Decide how this can be represented in MEI label Apr 16, 2021
@lpugin
Copy link
Member

lpugin commented Apr 16, 2021

Actually staffDef@ontheline looks appropriate to make this distinction. For the latest example above I would assume expect:

<staffDef lines="5" ontheline="false"/>

@kepper
Copy link
Member

kepper commented Apr 21, 2021

well, @ontheline currently has a slightly different meaning (according to it's description). It determines the placement of notes on a 1-line staff. A value of 'true' places all notes on the line, while a value of 'false' places stems-up notes above the line and stems-down notes below the line. I'm not sure this default placement is sufficient for our use case, but we could model something very similar just for tab, maybe called @ontheline.tab (or some such).

@kepper
Copy link
Member

kepper commented Apr 21, 2021

Just to get back to the idea of invisible staff lines above, even though they seem to be less of a solution: There is @lines, but there's also @lines.color (see https://music-encoding.org/guidelines/dev/attribute-classes/att.staffDef.vis.html#attributes_class), which is supposed to get as many values as there are lines, and the documentation explicitly mentions that this may be used to make lines invisible…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need clarification Decide how this can be represented in MEI need MEI customization Write the MEI customization to enable this
Projects
None yet
Development

No branches or pull requests

4 participants