From 43002ce6abd009876e7e30f383c6bd3abaa74bc5 Mon Sep 17 00:00:00 2001
From: Marc Wouts <marc.wouts@gmail.com>
Date: Sat, 30 Mar 2024 13:30:15 +0000
Subject: [PATCH] Explicit encoding argument in read_text()

---
 docs/changelog.md         | 1 +
 src/itables/javascript.py | 4 ++--
 src/itables/version.py    | 2 +-
 3 files changed, 4 insertions(+), 3 deletions(-)

diff --git a/docs/changelog.md b/docs/changelog.md
index 39a904da..1c672940 100644
--- a/docs/changelog.md
+++ b/docs/changelog.md
@@ -5,6 +5,7 @@ ITables ChangeLog
 ------------------
 
 **Fixed**
+- We have added an explicit `encoding` argument in the calls to `read_text` to address an issue seen on Windows ([#252](https://github.com/mwouts/itables/issues/252)).
 - We have adjusted the codecov settings ([#280](https://github.com/mwouts/itables/pull/280))
 
 
diff --git a/src/itables/javascript.py b/src/itables/javascript.py
index f80a0f0c..3e291df9 100644
--- a/src/itables/javascript.py
+++ b/src/itables/javascript.py
@@ -128,8 +128,8 @@ def get_animated_logo(display_logo_when_loading):
 
 def generate_init_offline_itables_html(dt_bundle: Path):
     assert dt_bundle.suffix == ".js"
-    dt_src = dt_bundle.read_text()
-    dt_css = dt_bundle.with_suffix(".css").read_text()
+    dt_src = dt_bundle.read_text(encoding="utf-8")
+    dt_css = dt_bundle.with_suffix(".css").read_text(encoding="utf-8")
     dt64 = b64encode(dt_src.encode("utf-8")).decode("ascii")
 
     id = "itables_init_notebook_mode_" + str(uuid.uuid4()).replace("-", "_")
diff --git a/src/itables/version.py b/src/itables/version.py
index 0087b58d..7d7dd69b 100644
--- a/src/itables/version.py
+++ b/src/itables/version.py
@@ -1,3 +1,3 @@
 """ITables' version number"""
 
-__version__ = "2.1.0"
+__version__ = "2.1.1-dev"