diff --git a/docs/changelog.md b/docs/changelog.md index 7d8656fc..01a124c6 100644 --- a/docs/changelog.md +++ b/docs/changelog.md @@ -6,6 +6,7 @@ ITables ChangeLog **Fixed** - We have adjusted the generation of the Polars sample dataframes to fix the CI ([Polars-18130](https://github.com/pola-rs/polars/issues/18130)) +- The test on the Shiny app uses `ui.nav_panel` which replaces `ui.nav` 2.1.4 (2024-07-03) diff --git a/tests/sample_python_apps/itables_in_a_shiny_app.py b/tests/sample_python_apps/itables_in_a_shiny_app.py index c849b727..dd6ac1e2 100644 --- a/tests/sample_python_apps/itables_in_a_shiny_app.py +++ b/tests/sample_python_apps/itables_in_a_shiny_app.py @@ -1,3 +1,4 @@ +# Run this app with "shiny run file.py" from shiny import App, ui from itables.sample_dfs import get_countries @@ -8,4 +9,3 @@ app_ui = ui.page_fluid(ui.HTML(DT(df))) app = App(app_ui, server=None) -# app.run() diff --git a/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py b/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py index 916cef2e..26171cb1 100644 --- a/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py +++ b/tests/sample_python_apps/itables_in_a_shiny_app_with_tabs.py @@ -1,3 +1,4 @@ +# Run this app with "shiny run file.py" from shiny import App, ui from itables.sample_dfs import get_dict_of_test_dfs @@ -6,9 +7,11 @@ app_ui = ui.page_fluid( # Display the different tables in different tabs ui.navset_tab( - *[ui.nav(name, ui.HTML(DT(df))) for name, df in get_dict_of_test_dfs().items()] + *[ + ui.nav_panel(name, ui.HTML(DT(df))) + for name, df in get_dict_of_test_dfs().items() + ] ) ) app = App(app_ui, server=None) -# app.run()