Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnicodeDecodeError while set "connected=False" #285

Closed
Samox1 opened this issue Jun 7, 2024 · 5 comments · Fixed by #253
Closed

UnicodeDecodeError while set "connected=False" #285

Samox1 opened this issue Jun 7, 2024 · 5 comments · Fixed by #253

Comments

@Samox1
Copy link

Samox1 commented Jun 7, 2024

I encountered a problem the first time I ran in jupyter notebook - the file contains only:

from itables import init_notebook_mode
init_notebook_mode(all_interactive=True, connected=False)

Error:

UnicodeDecodeError                        Traceback (most recent call last)
Cell In[3], [line 2](vscode-notebook-cell:?execution_count=3&line=2)
      [1] from itables import init_notebook_mode
----> [2] init_notebook_mode(all_interactive=True, connected=False)


[...]

File ~\AppData\Local\Programs\Python\Python310\lib\encodings\cp1250.py:23, in IncrementalDecoder.decode(self, input, final)
     [22] def decode(self, input, final=False):
---> [23]     return codecs.charmap_decode(input,self.errors,decoding_table)[0]

UnicodeDecodeError: 'charmap' codec can't decode byte 0x83 in position 194869: character maps to <undefined>

When set "connected=True" everything works properly.

itables version 2.1.0

@mwouts
Copy link
Owner

mwouts commented Jun 7, 2024

Hi @Samox1 , thank you for reporting this! This problem was initially reported at #252 and I have a PR ready to be tested in #253, but I could never reproduce the issue myself so I'd like to get confirmation that it does solve the issue before merging.

Do you think you could try the instruction here to test the PR? You will have to install nodejs. If that does not work for you let me know and I will publish a release candidate.

@mwouts
Copy link
Owner

mwouts commented Jun 8, 2024

Actually I have just released itables=2.1.1 with the fix. Let me know how it goes.

@Samox1
Copy link
Author

Samox1 commented Jun 8, 2024

Oh sorry, I looked for this problem in Issues but couldn't find it, that's why I described the problem.

I will check this issue in the near future and let you know.

@mwouts
Copy link
Owner

mwouts commented Jun 8, 2024

No problem at all! Thanks for reporting the issue. Sure, keep me posted!

@Samox1
Copy link
Author

Samox1 commented Jun 9, 2024

Tested on new venv - init_notebook_mode(all_interactive=True, connected=False) works without issue - really love this simple view!

Tested on: Windows 10 / Python 3.10.7 / ipynb in VS Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants