Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

indexQuery method includes softDeleted models. #24

Open
gregorip02 opened this issue Sep 29, 2020 · 4 comments
Open

indexQuery method includes softDeleted models. #24

gregorip02 opened this issue Sep 29, 2020 · 4 comments
Labels
bug Something isn't working
Milestone

Comments

@gregorip02
Copy link
Contributor

It is a good idea to exclude global scopes to increase query performance, but there is a problem when models are softDeleted because they keep showing up in the indexQuery.

We can solve it by overwriting this method in our resource, but it should ignore the softDeleted models by default.

@Larsklopstra
Copy link
Contributor

I'm not a fan of soft deletes but I guess we could support this

@Larsklopstra Larsklopstra added the bug Something isn't working label Sep 29, 2020
@Larsklopstra Larsklopstra added this to the v1.0.0 milestone Sep 29, 2020
@Larsklopstra
Copy link
Contributor

Perhaps a more flexible filter with "Includes trashed"

@ryangjchandler
Copy link
Contributor

Perhaps a more flexible filter with "Includes trashed"

I'd go down this route of providing a filter for including trashed / deleted items.

@gregorip02
Copy link
Contributor Author

Perhaps a more flexible filter with "Includes trashed"

Awesome, this will work.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants