Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

act push includes runs that specify branches that don't match my current branch #2489

Open
alunduil-gs opened this issue Oct 17, 2024 · 2 comments
Labels
kind/bug Something isn't working

Comments

@alunduil-gs
Copy link

Bug report info

act version:            0.2.68
GOOS:                   darwin
GOARCH:                 arm64
NumCPU:                 8
Docker host:            DOCKER_HOST environment variable is not set
Sockets found:
        /var/run/docker.sock
        $HOME/.docker/run/docker.sock
Config files:           
        /Users/alex.brandt/Library/Application Support/act/actrc:
                -P ubuntu-latest=catthehacker/ubuntu:full-latest
                -P ubuntu-22.04=catthehacker/ubuntu:full-22.04
                -P ubuntu-20.04=catthehacker/ubuntu:full-20.04
                -P ubuntu-18.04=catthehacker/ubuntu:full-18.04
Build info:
        Go version:            go1.23.1
        Module path:           command-line-arguments
        Main version:          
        Main path:             
        Main checksum:         
        Build settings:
                -buildmode:           exe
                -compiler:            gc
                -ldflags:             -X main.version=0.2.68
                DefaultGODEBUG:       asynctimerchan=1,gotypesalias=0,httplaxcontentlength=1,httpmuxgo121=1,httpservecontentkeepheaders=1,tls10server=1,tls3des=1,tlskyber=0,tlsrsakex=1,tlsunsafeekm=1,winreadlinkvolume=0,winsymlink=0,x509keypairleaf=0,x509negativeserial=1
                CGO_ENABLED:          1
                CGO_CFLAGS:           
                CGO_CPPFLAGS:         
                CGO_CXXFLAGS:         
                CGO_LDFLAGS:          
                GOARCH:               arm64
                GOOS:                 darwin
                GOARM64:              v8.0
Docker Engine:
        Engine version:        27.2.0
        Engine runtime:        runc
        Cgroup version:        2
        Cgroup driver:         cgroupfs
        Storage driver:        overlayfs
        Registry URI:          https://index.docker.io/v1/
        OS:                    Docker Desktop
        OS type:               linux
        OS version:            
        OS arch:               aarch64
        OS kernel:             6.10.4-linuxkit
        OS CPU:                8
        OS memory:             7839 MB
        Security options:
                name=seccomp,profile=unconfined
                name=cgroupns

Command used with act

act -l push

Describe issue

I expected workflows that were not applicable (such as those restricted to master) to not be listed as part of the run, but they are included which means some merge to master flows will be attempted.

Link to GitHub repository

No response

Workflow content

on:
  push:
    branches:
      - 'master'
      - 'release/**'
  workflow_dispatch:

Relevant log output

I'm not sure this is relevant, but will include it if necessary.

Additional information

I've stripped the workflow description to only the selection criteria but let me know if that's too stripped back and I can work to find a better reproduction for this.

I may also just be having incorrect expectations since I want to use act to run workflows as a sanity check instead of other local testing methodologies but we have quite complex workflows defined currently.

@alunduil-gs alunduil-gs added the kind/bug Something isn't working label Oct 17, 2024
@kinson-liu
Copy link

kinson-liu commented Nov 24, 2024

I also got this issue. I see the code, the planner just loads workflows and filter the events. It doesn't check the branches in the push event.

@ChristopherHX
Copy link
Contributor

ChristopherHX commented Nov 24, 2024

If these would be skipped without notice, what would you do if you want to run them?

There is -W to select a single workflow yaml file, for example this command act -W .github/workflows/merge_to_master.yml push may just do nothing.

I need a clear proposal, until then this is an incomplete feature request (packed into a bug report) that cannot be added to my backlog

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants