Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfigureAwaits #17

Open
MgSam opened this issue Apr 20, 2023 · 1 comment · May be fixed by #19
Open

ConfigureAwaits #17

MgSam opened this issue Apr 20, 2023 · 1 comment · May be fixed by #19

Comments

@MgSam
Copy link

MgSam commented Apr 20, 2023

Hi,

I'm assuming the lack of ConfigureAwait(false) in https://github.com/neosmart/AsyncLock/blob/master/AsyncLock/AsyncLock.cs means that you intend the default, ConfigureAwait(true)? I just wanted to double check if that is the case, and if so, ask that maybe you make it explicit?

Thank you!
@mqudsi
Copy link
Member

mqudsi commented Apr 23, 2023

Hi Sam,

if that is the case, and if so, ask that maybe you make it explicit?

This is definitely a good idea since now I cannot remember, though I'm fairly sure I considered it!
I guess I'll have to dig in and try to work backwards..

@NetherGranite NetherGranite linked a pull request Jul 1, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't marshal async continuations to the captured context NetherGranite/AsyncLock
2 participants
@mqudsi @MgSam