Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview of non-UTF-8 text is not working #351

Closed
marinofaggiana opened this issue Aug 16, 2017 · 5 comments
Closed

Preview of non-UTF-8 text is not working #351

marinofaggiana opened this issue Aug 16, 2017 · 5 comments
Labels
bug
Milestone
v2.17.6

Comments

@marinofaggiana
Copy link
Member

  • open a file with special characters, that is not UTF-8 encoded (like an ó)
  • actual: the file is not properly rendered
  • expected: proper rendering
marinofaggiana added a commit that referenced this issue Aug 16, 2017
@marinofaggiana
#351
25eb192
marinofaggiana added a commit that referenced this issue Aug 16, 2017
@marinofaggiana
Apply #351
bcdd7b8
@marinofaggiana
Copy link
Member Author

marinofaggiana commented Aug 16, 2017 •
edited
Loading

  • Use library : https://cgit.freedesktop.org/uchardet/uchardet/ uchardet started as a C language binding of the original C++ implementation of the universal charset detection library by Mozilla.
  • Write a wrapper NCUchardet
  • Include wrapper on Swift

marinofaggiana added a commit that referenced this issue Aug 16, 2017
@marinofaggiana
Add license, version #351
3f2627b
@marinofaggiana marinofaggiana added this to the v2.17.6 milestone Aug 16, 2017
@marinofaggiana
Copy link
Member Author

Apply version 0.0.6 stable : BYVoid/uchardet#36 (comment)

@rakekniven
Copy link
Member

Related: #13

@rakekniven
Copy link
Member

@marinofaggiana This is working AFAICS, or?

@marinofaggiana
Copy link
Member Author

yes thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
v2.17.6
Development

No branches or pull requests
3 participants
@MorrisJobke @rakekniven @marinofaggiana