Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Colored whitespaces trimmed #650

Closed
KapJI opened this issue Nov 5, 2024 · 2 comments
Closed

Colored whitespaces trimmed #650

KapJI opened this issue Nov 5, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@KapJI
Copy link

KapJI commented Nov 5, 2024

When using delta colored lines at the end are trimmed.

less

[delta]
side-by-side = true
pager = "less -F"
Screenshot 2024-11-05 at 19 07 56

ov

[delta]
side-by-side = true
pager = "ov -F"
Screenshot 2024-11-05 at 19 08 20

Is this a bug? Or can this be configured?
@noborus
Copy link
Owner

noborus commented Nov 6, 2024

Thank you for sending issue.
The cause is that the ov has not yet supported the Erase in Line of Ansi Control Sequences.
I'm going to add that support.

@noborus noborus added the enhancement New feature or request label Nov 6, 2024
noborus added a commit that referenced this issue Nov 7, 2024
@noborus
Add support of ANSI escape sequence for clear line
c676eed 
ov(and other pagers) cannot be erased.
Actually, set the style from the end of the line.
This solves #650 .
@noborus noborus mentioned this issue Nov 7, 2024
Merged
@KapJI
Copy link
Author

KapJI commented Nov 9, 2024

Fixed by #651

@KapJI KapJI closed this as completed Nov 9, 2024
tmeijn pushed a commit to tmeijn/dotfiles that referenced this issue Nov 22, 2024
@tmeijn
build(deps): update noborus/ov to v0.37.0
2085a5b 
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [noborus/ov](https://github.com/noborus/ov) | minor | `v0.36.0` -> `v0.37.0` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>noborus/ov (noborus/ov)</summary>

### [`v0.37.0`](https://github.com/noborus/ov/releases/tag/v0.37.0)

[Compare Source](noborus/ov@v0.36.0...v0.37.0)

#### What's Changed

Thank you for working on this release.
[@&#8203;aoyama-val](https://github.com/aoyama-val) [@&#8203;ccoveille](https://github.com/ccoveille) [@&#8203;kapji](https://github.com/kapji) [@&#8203;yosagi](https://github.com/yosagi) [@&#8203;bprb](https://github.com/bprb)

##### Add a converter

Escape sequence support has been changed from essential to selectable as a converter.
There are converters: an interpretation of escape sequence (default), `raw`, which does not interpret escape sequence, and `align`.
The columns can be shrinked, if the converter is aligned.

noborus/ov#609   noborus/ov#610 noborus/ov#611 noborus/ov#612 noborus/ov#614 noborus/ov#615 noborus/ov#617 noborus/ov#618 noborus/ov#619 noborus/ov#623 noborus/ov#624  noborus/ov#625  noborus/ov#626 noborus/ov#627 noborus/ov#631

##### Change specifications of suspend

The suspend is suspended correctly, not sub-shell.
Thank you to [@&#8203;yosagi](https://github.com/yosagi).

-   Change to suspend with SIGSTOP by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#632
-   Send SIGSTOP to the process group by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#639
-   STDIN switching when using Subshell by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#640

##### Changed redirect specifications

-   Change to Do not display screen when redirecting by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#638
    (Fix noborus/ov#634).

##### Fix bugs and improvements

-   Fix paste mistakes by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#616 (Fix noborus/ov#613)
-   Avoid sector header when marking by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#621 (Fix noborus/ov#620)
-   Change the style-related function name by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#628
-   help descriptions for better clarity by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#635
-   Fix the issue where the version contains "-1" by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#637 Fix noborus/ov#636)
-   Fixed root.searcher is race condition by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#642 (Fix noborus/ov#641)
-   Fix linkage of filter documents with headers by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#644
-   Improve follow/followAll/followSection by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#645
-   Add support of ANSI escape sequence for clear line by [@&#8203;noborus](https://github.com/noborus) in noborus/ov#651 (Fix noborus/ov#650)

**Full Changelog**: noborus/ov@v0.36.0...v0.37.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40NDAuNyIsInVwZGF0ZWRJblZlciI6IjM3LjQ0MC43IiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@noborus @KapJI