diff --git a/src/base_object-inl.h b/src/base_object-inl.h index da8fed7b301..518b22dabef 100644 --- a/src/base_object-inl.h +++ b/src/base_object-inl.h @@ -132,14 +132,14 @@ v8::EmbedderGraph::Node::Detachedness BaseObject::GetDetachedness() const { template void BaseObject::InternalFieldGet( - v8::Local property, + v8::Local property, const v8::PropertyCallbackInfo& info) { info.GetReturnValue().Set( info.This()->GetInternalField(Field).As()); } -template -void BaseObject::InternalFieldSet(v8::Local property, +template +void BaseObject::InternalFieldSet(v8::Local property, v8::Local value, const v8::PropertyCallbackInfo& info) { // This could be e.g. value->IsFunction(). diff --git a/src/base_object.h b/src/base_object.h index b0ada1d7f38..fd6d62a99ce 100644 --- a/src/base_object.h +++ b/src/base_object.h @@ -111,10 +111,10 @@ class BaseObject : public MemoryRetainer { // Setter/Getter pair for internal fields that can be passed to SetAccessor. template - static void InternalFieldGet(v8::Local property, + static void InternalFieldGet(v8::Local property, const v8::PropertyCallbackInfo& info); template - static void InternalFieldSet(v8::Local property, + static void InternalFieldSet(v8::Local property, v8::Local value, const v8::PropertyCallbackInfo& info); diff --git a/src/node_builtins.cc b/src/node_builtins.cc index bbb63df7899..701b67568eb 100644 --- a/src/node_builtins.cc +++ b/src/node_builtins.cc @@ -11,7 +11,6 @@ namespace node { namespace builtins { using v8::Context; -using v8::DEFAULT; using v8::EscapableHandleScope; using v8::Function; using v8::FunctionCallbackInfo; @@ -711,7 +710,6 @@ void BuiltinLoader::CreatePerIsolateProperties(IsolateData* isolate_data, nullptr, Local(), None, - DEFAULT, SideEffectType::kHasNoSideEffect); target->SetNativeDataProperty(FIXED_ONE_BYTE_STRING(isolate, "builtinIds"), @@ -719,7 +717,6 @@ void BuiltinLoader::CreatePerIsolateProperties(IsolateData* isolate_data, nullptr, Local(), None, - DEFAULT, SideEffectType::kHasNoSideEffect); target->SetNativeDataProperty( @@ -728,7 +725,6 @@ void BuiltinLoader::CreatePerIsolateProperties(IsolateData* isolate_data, nullptr, Local(), None, - DEFAULT, SideEffectType::kHasNoSideEffect); target->SetNativeDataProperty(FIXED_ONE_BYTE_STRING(isolate, "natives"), @@ -736,7 +732,6 @@ void BuiltinLoader::CreatePerIsolateProperties(IsolateData* isolate_data, nullptr, Local(), None, - DEFAULT, SideEffectType::kHasNoSideEffect); SetMethod(isolate, target, "getCacheUsage", BuiltinLoader::GetCacheUsage); diff --git a/src/node_external_reference.h b/src/node_external_reference.h index 8b47831769d..f66bdf40c2a 100644 --- a/src/node_external_reference.h +++ b/src/node_external_reference.h @@ -57,8 +57,6 @@ class ExternalReferenceRegistry { V(CFunctionWithBool) \ V(const v8::CFunctionInfo*) \ V(v8::FunctionCallback) \ - V(v8::AccessorGetterCallback) \ - V(v8::AccessorSetterCallback) \ V(v8::AccessorNameGetterCallback) \ V(v8::AccessorNameSetterCallback) \ V(v8::GenericNamedPropertyDefinerCallback) \