Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Windows MSI installer creates doc shortcut with wrong URL #43

Open
vsemozhetbyt opened this issue Mar 13, 2018 · 7 comments
Open

Windows MSI installer creates doc shortcut with wrong URL #43

vsemozhetbyt opened this issue Mar 13, 2018 · 7 comments

Comments

@vsemozhetbyt
Copy link

vsemozhetbyt commented Mar 13, 2018 •
edited
Loading

Meaning this shortcut in Start menu:
cdocs

For example, in this build:

https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/

Proper URL: https://nodejs.org/download/v8-canary/v10.0.0-v8-canary20180306870146ff63/docs/api/

Shortcut URL: https://nodejs.org/download/custom/v10.0.0-v8-canary20180306870146ff63/docs/api/ (404)
@targos
Copy link
Member

targos commented Mar 13, 2018

@nodejs/build

@piccoloaiutante
Copy link
Member

After a quick look it seems that that portion of URL is driven by DistTypeDir:

https://github.com/nodejs/node-v8/blob/canary/tools/msvs/msi/product.wxs#L261

And that variable is set into build.bat from server:

node-v8/vcbuild.bat

Line 344 in fecbce4

msbuild "%~dp0tools\msvs\msi\nodemsi.sln" /m /t:Clean,Build %msbsdk% /p:PlatformToolset=%PLATFORM_TOOLSET% /p:GypMsvsVersion=%GYP_MSVS_VERSION% /p:Configuration=%config% /p:Platform=%target_arch% /p:NodeVersion=%NODE_VERSION% /p:FullVersion=%FULLVERSION% /p:DistTypeDir=%DISTTYPEDIR% %noetw_msi_arg% %noperfctr_msi_arg% /clp:NoSummary;NoItemAndPropertyList;Verbosity=minimal /nologo

I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?

@gibfahn
Copy link
Member

gibfahn commented Mar 14, 2018

I guess it will be a matter to to set it properly into jenkins, isn't it @gibfahn ?

DistTypeDir is set in the ci-release job from DISTTYPE, which is a parameter in the job:

image

It should be release for regular releases.

@joaocgreis
Copy link
Member

DISTTYPE and DISTTYPEDIR are changed to custom by the build script when building v8-canaries (and others). The correct variable to use should be RELEASE_URLBASE.

@targos
Copy link
Member

targos commented May 1, 2018

So what needs to be changed to fix this?

@refack refack self-assigned this Sep 16, 2018
@targos
Copy link
Member

targos commented Jan 20, 2019

Is it still an issue?

@vsemozhetbyt
Copy link
Author

For the last Canary build for Windows (as of 2019-01-02), yes, the issue still exists.

@refack refack removed their assignment Jun 1, 2019
nodejs-ci pushed a commit that referenced this issue Aug 24, 2019
@isaacs @Trott
deps: update npm to 6.10.3
f769034 
BUGFIXES

* [`27cccfbda`](npm/cli@27cccfb)
  [#223](npm/cli#223) vulns → vulnerabilities in
  npm audit output ([@sapegin](https://github.com/sapegin))
* [`d5e865eb7`](npm/cli@d5e865e)
  [#222](npm/cli#222)
  [#226](npm/cli#226) install, doctor: don't crash
  if registry unset ([@dmitrydvorkin](https://github.com/dmitrydvorkin),
  [@isaacs](https://github.com/isaacs))
* [`5b3890226`](npm/cli@5b38902)
  [#227](npm/cli#227)
  [npm.community#9167](https://npm.community/t/npm-err-cb-never-called-permission-denied/9167/5)
  Handle unhandledRejections, tell user what to do when encountering an
  `EACCES` error in the cache.  ([@isaacs](https://github.com/isaacs))

DEPENDENCIES

* [`77516df6e`](npm/cli@77516df)
  `licensee@7.0.3` ([@isaacs](https://github.com/isaacs))
* [`ceb993590`](npm/cli@ceb9935)
  `query-string@6.8.2` ([@isaacs](https://github.com/isaacs))
* [`4050b9189`](npm/cli@4050b91)
  `hosted-git-info@2.8.2`
    * [#46](npm/hosted-git-info#46)
      [#43](npm/hosted-git-info#43)
      [#47](npm/hosted-git-info#47)
      [#44](npm/hosted-git-info#44) Add support for
      GitLab subgroups ([@mterrel](https://github.com/mterrel),
      [@isaacs](https://github.com/isaacs),
      [@ybiquitous](https://github.com/ybiquitous))
    * [`3b1d629`](npm/hosted-git-info@3b1d629)
      [#48](npm/hosted-git-info#48) fix http
      protocol using sshurl by default
      ([@fengmk2](https://github.com/fengmk2))
    * [`5d4a8d7`](npm/hosted-git-info@5d4a8d7)
      ignore noCommittish on tarball url generation
      ([@isaacs](https://github.com/isaacs))
    * [`1692435`](npm/hosted-git-info@1692435)
      use gist tarball url that works for anonymous gists
      ([@isaacs](https://github.com/isaacs))
    * [`d5cf830`](npm/hosted-git-info@d5cf830)
      Do not allow invalid gist urls ([@isaacs](https://github.com/isaacs))
    * [`e518222`](npm/hosted-git-info@e518222)
      Use LRU cache to prevent unbounded memory consumption
      ([@iarna](https://github.com/iarna))

PR-URL: nodejs/node#29023
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@refack @joaocgreis @piccoloaiutante @targos @vsemozhetbyt @gibfahn