-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Visually differentiate H2 from H3 headings in Metabar Table of Contents #7275
Comments
+1 for that |
visually perhaps, but the headings are not rendered as h2, h3 etc in the metabar, it's a definition list entry see the code at nodejs.org/apps/site/components/Containers/MetaBar/index.tsx Lines 41 to 53 in fbd443d
see https://nodejs.org/en/learn/test-runner/mocking <div class="MetaBar_wrapper__Th_dl">
<dl>
<dt>Table of Contents</dt>
<dd>
<ol>
<li>
<a href="#when-and-not-to-mock">When and not to mock</a>
</li>
<li>
<a href="#own-code">Own code</a>
</li>
<li>
<a href="#why">Why</a>
</li>
<li>
<a href="#why-not">Why not</a>
</li>
<li>
<a href="#external-code">External code</a>
</li>
<li>
<a href="#why-1">Why</a>
</li>
<li>
<a href="#why-not-1">Why not</a>
</li>
<li>
<a href="#external-system">External system</a>
</li>
<li>
<a href="#what-to-mock">What to mock</a>
</li>
<li>
<a href="#modules--units">Modules + units</a>
</li>
<li>
<a href="#apis">APIs</a>
</li>
<li>
<a href="#time">Time</a>
</li>
</ol>
</dd>
</dl>
</div>; |
Hello @bmuenzenmeyer |
@AugustinMauroy @bmuenzenmeyer may I work on this issue? |
You can work on we don't assign issue |
Visually indicate the difference between an H2 and H3 heading.
This could be indentation or other textual formatting. Whatever it is, make sure it is responsive and does not create a lot of flow problems. For instance, do not indent many many pixels, as that just makes the headings wrap and become longer.
I like the heading hierarchy of the content - it'd be nice if we visually indicated the indentation level. I think H2 and H3 only.
Look at content like https://nodejs.org/en/learn/test-runner/mocking for similar needs.
Originally posted by @bmuenzenmeyer in #7215 (comment)
The text was updated successfully, but these errors were encountered: