-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workbench theming #8
Comments
I definitely planned to add UI support or, if the VS Code team splits up theming into multiple theme packages like Atom, to create a new UI theme package. I scrolled through the issue you linked and it seems like the UI API will be added to the March release.
Maybe I'll wait until the April release is ready so I can update to the whole new theming API I've also mentioned in one of the comments linked above 😄 |
@arcticicestudio It'd be great if you could start adapting Nord to the new API after the March release. It seems the new API will be available in Insiders during April. The "many changes" to the API is a reaction to the feedback VSCode has gotten. So if you need something for Nord that is not available through API yet, you can leave feedback to VSCode and they will probably change the API to adapt needs. This is more work, but it benefits all VSCode theme authors (a better theming API) and makes Nord a well-integrated theme to VSCode. I'm using Nord for Vim and iTerm, and I really want it for VSCode. |
Thanks I tried it and added "titleBarActiveBackground": "#485264" same for Inactive, but can't find the color option for terminal dropdown menu and intellisense. |
Well, version 1.11 has been released, but they've added this to the changelog:
Users can set some attributes on their own to adjust the workbench to fit the syntax theme as posted by @nomenon and also mentioned in the changelog:
@octref I've added a project card to keep track of the new theming API changes and will start to work on it as soon as the changes are merged into the Insider version for theme authors to adapt the API. |
Sounds great. Really looking forward to next month's release and nord's update :D |
I've created #11 which implements the new workbench theming- and JSON theme format API. |
The "contrastBorder" and "contrastActiveBorder" also effecting the background of the elements they are applied on.
I also tried to theme the workbench, is not complete but here's my take on it:
|
Now using "nord12" to increase the readability
Changed from 75% to 30% to increase the readability.
Now using nord1 instead of nord2 to match the background color of inactive selected list elements.
Now using nord8 with 60% transparency to differ from active selected list elements. This also improves navigating the list using the keyboard.
Avid user of nord palettes here!
I was wondering if you are putting in any work towards the new workbench theming that is going to come to vscode.
microsoft/vscode#3112
I would love to see nord more integrated into vscode like it is in atom with Nord UI. I would be willing to help you on this as well?
The text was updated successfully, but these errors were encountered: