Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Intellij, language server logs always end in a newline #2282

Open
aqeelat opened this issue Oct 10, 2024 · 0 comments
Open

In Intellij, language server logs always end in a newline #2282

aqeelat opened this issue Oct 10, 2024 · 0 comments
Labels
type: bug Something isn't working

Comments

@aqeelat
Copy link

aqeelat commented Oct 10, 2024

Current Behavior

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - Refresh workspace started called from nxls
2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Retrieving workspace configuration

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Using local Nx package at {project_root}/node_modules/nx/src/project-graph/file-utils.js

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Using local Nx package at {project_root}/node_modules/nx/src/project-graph/project-graph.js

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Using local Nx package at{project_root}/node_modules/nx/src/project-graph/file-map-utils.js

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Using local Nx package at {project_root}/node_modules/nx/src/daemon/client/client.js

2024-10-10 13:45:12,827 [165160238]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.827Z - Using local Nx package at {project_root}/node_modules/nx/src/utils/output.js

2024-10-10 13:45:12,829 [165160240]   INFO - #dev.nx.console.nxls.client.NxlsLanguageClient - [Nxls] - 2024-10-10T10:45:12.828Z - createProjectGraphAndSourceMapsAsync

Some logs coming from NxlsLanguageClient have an extra newline. However, the offending logs are not present in the KT code, but rather in the language server.

These logs are fine:

@JsonNotification("nx/refreshWorkspaceStarted")
fun refreshWorkspaceStarted() {
log.info("Refresh workspace started called from nxls")
refreshStartedCallback.forEach { it() }
}

Expected Behavior

For the logs to not have this newline. This is making the logs harder to read (usually empty lines mean there are stack traces coming after them)

Steps to Reproduce

Install plugin
View IDE logs

Failure Logs / Images / Videos

Environment

  • Nx Console version: 1.32.2
  • VSCode version:
@aqeelat aqeelat added the type: bug Something isn't working label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant