Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix balance contract to use prefixes for accounts #337

Closed
roman-khimov opened this issue Apr 19, 2023 · 1 comment
Closed

Fix balance contract to use prefixes for accounts #337

roman-khimov opened this issue Apr 19, 2023 · 1 comment
Labels
balance Balance contract related issue enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U4 Nothing urgent
Milestone
v0.20.0

Comments

@roman-khimov
Copy link
Member

Using uint160 for storage keys directly is always a bad idea, it may clash with something else one way or another. A prefix is needed to have everything always working correctly.
@roman-khimov roman-khimov added balance Balance contract related issue refactor labels Apr 19, 2023
@roman-khimov roman-khimov added this to the v0.18.0 milestone Apr 19, 2023
@roman-khimov roman-khimov modified the milestones: v0.18.0, v0.19.0 Sep 21, 2023
@roman-khimov roman-khimov modified the milestones: v0.19.0, v0.20.0 Nov 22, 2023
@roman-khimov roman-khimov added enhancement Improving existing functionality I4 No visible changes U4 Nothing urgent S3 Minimally significant and removed refactor labels Dec 20, 2023
@roman-khimov
Copy link
Member Author

Fixed by #406.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
balance Balance contract related issue enhancement Improving existing functionality I4 No visible changes S3 Minimally significant U4 Nothing urgent
Projects
None yet
Milestone
v0.20.0
Development

No branches or pull requests
1 participant
@roman-khimov