Simple express app printing odd warning #3275

djMax · 2022-09-26T00:27:50Z

djMax
Sep 26, 2022

I'm trying to port a large and opinionated framework to Typescript and OpenTelemetry, and having some trouble with "clean" runs off the examples:

import * as opentelemetry from '@opentelemetry/sdk-node';
import { getNodeAutoInstrumentations } from '@opentelemetry/auto-instrumentations-node';
import { diag, DiagConsoleLogger, DiagLogLevel } from '@opentelemetry/api';

// For troubleshooting, set the log level to DiagLogLevel.DEBUG
diag.setLogger(new DiagConsoleLogger(), DiagLogLevel.INFO);

const sdk = new opentelemetry.NodeSDK({
  traceExporter: new opentelemetry.tracing.ConsoleSpanExporter(),
  instrumentations: [getNodeAutoInstrumentations()],
});

sdk.start().then(async () => {
  const [{ default: pino }, { default: express }] = await Promise.all([
    import('pino'),
    import('express'),
  ]);
  const logger = pino();
  logger.info('OpenTelemetry configured');

  const port = Number(process.env.PORT || '8080');
  const app = express();

  app.get('/', (req, res) => {
    res.send('Hello World');
  });

  app.listen(port, () => {
    logger.info({ port }, 'express listening');
  });

  // gracefully shut down the SDK on process exit
  process.on('SIGTERM', () => {
    sdk
      .shutdown()
      .then(() => logger.info('Tracing terminated'))
      .catch((error) => logger.error(error, 'Error terminating tracing'))
      .finally(() => process.exit(0));
  });
});

But it prints this "error" which I don't understand at all:

No modules instrumentation has been defined, nothing will be patched
{"level":30,"time":1664152000611,"pid":21412,"hostname":"MaxM1Max.local","msg":"OpenTelemetry configured"}
{"level":30,"time":1664152000616,"pid":21412,"hostname":"MaxM1Max.local","port":8080,"msg":"express listening"}

I also don't see spans in the pino logs. Should I?