GRPC Tracing Dropping trailers #5033
scott-clary
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
My GRPC Functions are defined as
function (call: grpc.ServerUnaryCall<any, any> | grpc.ServerReadableStream<any, any>, callback: grpc.sendUnaryData<any>) {
In them I return the callback with trailers added
return callback(null, {}, trailers);
Note sendUnaryData type
Unfortunately in the
experimental/packages/opentelemetry-instrumentation-grpc/src/serverUtils.ts
its using theSendUnaryDataCallback type which doesn't include the trailer or flags.
All this to say is this function should probably return trailers and flags in the callback, otherwise they are lost when tracing is turned on.
Beta Was this translation helpful? Give feedback.
All reactions