From 4d908453e7d50a918a357c5c3ca84bfca064b613 Mon Sep 17 00:00:00 2001
From: GonzaloGuasch <gonzalo.guasch@mercadolibre.com>
Date: Thu, 26 Dec 2024 12:46:12 -0300
Subject: [PATCH] update changelog && add test

---
 CHANGELOG.md                                         |  2 +-
 .../tests/test_wsgi_middleware.py                    | 12 ++++++++++++
 2 files changed, 13 insertions(+), 1 deletion(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index e3c065dd70..19a74422c2 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -19,7 +19,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
   ([#3111](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3111))
 - `opentelemetry-instrumentation-falcon` add support version to v4
   ([#3086](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3086))
-- `opentelemetry-instrumentation-wsgi` remove is_recording method to record status code in all metrics
+- `opentelemetry-instrumentation-wsgi` always record span status code to have it available in metrics
   ([#3148](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/3148))
 
 ### Fixed
diff --git a/instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py b/instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py
index da1a3c2696..bb1db4908a 100644
--- a/instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py
+++ b/instrumentation/opentelemetry-instrumentation-wsgi/tests/test_wsgi_middleware.py
@@ -779,6 +779,18 @@ def test_response_attributes(self):
         self.span.set_attribute.assert_has_calls(expected, any_order=True)
         self.span.set_attribute.assert_has_calls(expected_new, any_order=True)
 
+    def test_response_attributes_noop(self):
+        mock_span = mock.Mock()
+        mock_span.is_recording.return_value = False
+
+        attrs = {}
+        otel_wsgi.add_response_attributes(mock_span, "404 Not Found", {}, duration_attrs=attrs)
+
+        self.assertEqual(mock_span.set_attribute.call_count, 0)
+        self.assertEqual(mock_span.is_recording.call_count, 2)
+        self.assertEqual(attrs[SpanAttributes.HTTP_STATUS_CODE], 404)
+
+
     def test_credential_removal(self):
         self.environ["HTTP_HOST"] = "username:password@mock"
         self.environ["PATH_INFO"] = "/status/200"