Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows release archive doesn't have zimwriterfs #354

Open
shenlebantongying opened this issue Jun 18, 2023 · 8 comments
Open

Windows release archive doesn't have zimwriterfs #354

shenlebantongying opened this issue Jun 18, 2023 · 8 comments
Assignees
Milestone

Comments

@shenlebantongying
Copy link

Download https://download.openzim.org/release/zim-tools/zim-tools_win-i686-3.2.0-1.zip

There is no zimwriterfs.exe

@kelson42 kelson42 added the bug label Jun 18, 2023
@kelson42 kelson42 added this to the 3.3.0 milestone Jun 18, 2023
@kelson42
Copy link
Contributor

@mgautierfr Should I move the ticket to kiwix/kiwix-build?

@mgautierfr
Copy link
Collaborator

zimwriterfs has been introduced in zim-tools with #104
From the comments, it seems totally natural we don't build on Windows but we never say why.
I simply suspect that zimwriterfs is not totally ported on Windows.

@kelson42 kelson42 modified the milestones: 3.3.0, 3.4.0 Sep 26, 2023
@kelson42 kelson42 pinned this issue Sep 26, 2023
@kelson42 kelson42 modified the milestones: 3.4.1, 3.5.0 May 16, 2024
@kelson42 kelson42 modified the milestones: 3.4.2, 3.5.0 Jul 8, 2024
@kelson42
Copy link
Contributor

@mgautierfr An update would be welcome here

@mgautierfr
Copy link
Collaborator

zimwriterfs need libmagic to detect the mimetype of the added file and we currently cannot compile it on Windows.

@kelson42
Copy link
Contributor

kelson42 commented Aug 27, 2024

@mgautierfr Issue link? Filemagic should not be 100% indispensible AFAIK as we have anyway an extension based mime-type mapping table. This is good enough for 99% of the use case. This would be an acceptable workaround.

@mgautierfr
Copy link
Collaborator

There is this meta-issue : kiwix/kiwix-build#729

@kelson42
Copy link
Contributor

kelson42 commented Sep 2, 2024

At this stage, gumbo and libmagic are not available easily for compilation on Windows. For sure this is the case of libmagic. For this reason we still struggle to have zimwriterfs in the Windows release.

@kelson42 kelson42 modified the milestones: 3.5.0, 3.6.0 Sep 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants