Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buttons in ButtonGroup missing borders when mixed Button types are used #7000

Open
ggdouglas opened this issue Sep 25, 2024 · 0 comments
Open

Comments

@ggdouglas
Copy link
Contributor

ggdouglas commented Sep 25, 2024

Environment

  • Package version(s): 5.13.0
  • Browser name and version: Chrome 128

Description

A ButtonGroup that contains different types of buttons (e.g. minimal and outlined) can end up rendering some of the borders on the buttons incorrectly. For example, given the following setup:

<ButtonGroup>
  <Button icon="chevron-left" minimal />
  <Button rightIcon="caret-down" outlined>
    1
  </Button>
  <Button icon="chevron-right" minimal />
</ButtonGroup>

the middle outlined Button will render missing its right border.

Screenshot 2024-09-24 at 21 31 34@2x

Code Sandbox

This bug was introduced in v5.13.0, see before v5.12.x and after v.5.13.x

Possible solution

This issue was likely introduced in #6966. We should handle the case of mixed type buttons in ButtonGroup since it was handled previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant