Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TLS file content is not refreshable #221

Open
bmoylan opened this issue Oct 27, 2021 · 1 comment
Open

TLS file content is not refreshable #221

bmoylan opened this issue Oct 27, 2021 · 1 comment

Comments

@bmoylan
Copy link
Contributor

bmoylan commented Oct 27, 2021

In #171 we introduced refreshable configuration which reloads state based on a provided supplier. As a caveat, we we not able to implement refreshability for TLS (Security) parameters. Instead, a warning is logged if the values are updated.

A *tls.Config is more complex than the net and http structs because many of its struct fields are functional types which are not compatible with reflect.DeepEqual, used internally by the refreshables. Equality checking is important because we do not want unnecessary updates to downstream listeners.

There may be a solution involving an intermediate struct of all primitive types, but we need to continue to support things like certificate providers that poll on their own schedule. Maybe if they are interface types implemented by comparable structs we will get away with it, but this requires more thought and work.

@bmoylan bmoylan changed the title TLS configuration is not refreshable TLS file content is not refreshable Sep 24, 2024
@bmoylan
Copy link
Contributor Author

bmoylan commented Sep 24, 2024

Partially addressed in #689, but if the file contents themselves change, we'll continue using the old value

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant