Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unclear param precedence in client builder #31

Open
mnajork-palantir opened this issue Mar 27, 2019 · 0 comments
Open

Unclear param precedence in client builder #31

mnajork-palantir opened this issue Mar 27, 2019 · 0 comments

Comments

@mnajork-palantir
Copy link

mnajork-palantir commented Mar 27, 2019

The precedence of how params passed in via config (i.e. httpclient.WithConfig(config)) and params passed manually (i.e. httpclient.WithParam(param)) apply to the returned client is somewhat non-intuitive without diving into the code.

Can we document the precedence of params passed via the config struct versus params passed individually to the builder?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant