Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add carpet plot to the dispiking pipeline #104

Open
mhmadAbs opened this issue Aug 18, 2022 · 1 comment
Open

Add carpet plot to the dispiking pipeline #104

mhmadAbs opened this issue Aug 18, 2022 · 1 comment
Assignees

Comments

@mhmadAbs
Copy link
Contributor

Carpet plot will be generated as a qc step.
Create a Folder called carpet in which the carpet plot will be stored.

@mhmadAbs mhmadAbs self-assigned this Aug 18, 2022
@spisakt
Copy link
Member

spisakt commented Aug 18, 2022

Some more dettails:

  • a QC workflow with the @QcPipeline decorator which wraps the carpet plot function, saves its output into the working directory (this may be best to achieve with an additional wrapper function, but for composite plots later, we must retain the current function, too, which returns the matplotlib object)
  • the name of the png file should be based on the basename of the nii file it is based on, extended with a "_carpet.png" and located in the workflow's working directory (managed automatically). See https://github.com/pni-lab/PUMI/blob/main/PUMI/utils.py:line282-290 for an example.
  • this QC workflow must be added to the despike workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants