Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing .yo-rc.json files in some samples #5332

Open
9 tasks
ervingayle opened this issue Nov 8, 2024 · 3 comments
Open
9 tasks

Missing .yo-rc.json files in some samples #5332

ervingayle opened this issue Nov 8, 2024 · 3 comments
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs

Comments

@ervingayle
Copy link
Contributor

Disclaimer

Yes

Sample

https://github.com/pnp/sp-dev-fx-webparts/tree/main/samples/react-accordion-dynamic-section

Contributor(s)

@ejbenke

What happened?

I noticed that the yo-rc.json file is missing from a few samples in the gallery. While this does not affect the functionality of the components, it does impact the ability to leverage the vscode spfx extension actions. Initially, I opened a ticket in that repo but via the discussion, it was recommended that I open an issue here.
Here is the discussion: Issue
This came to light for me during the recent hacktoberfest and upgrading this solution from an earlier version of SPFx

Steps to reproduce

  1. Download a sample and open it in VS Code
  2. Install VS Code Viva SPFx extension
  3. Open solution in VS Code. Solution actions will not appear along with context actions

Expected behavior

VS Code extension actions should appear

Target SharePoint environment

SharePoint Online

Developer environment

None

Browsers

  • Internet Explorer
  • Microsoft Edge
  • Google Chrome
  • FireFox
  • Safari
  • mobile (iOS/iPadOS)
  • mobile (Android)
  • not applicable
  • other (enter in the "Additional environment details" area below)

What version of Node.js is currently installed on your workstation?

18.18.0

What version of Node.js is required by the sample?

18.18.0

Paste the results of SPFx doctor

PS C:\Github\sp-dev-fx-webparts\samples\react-accordion-dynamic-section> m365 spfx doctor -o text

CLI for Microsoft 365 SharePoint Framework doctor
Verifying configuration of your system for working with the SharePoint Framework

√ SharePoint Framework v1.20.0
√ Node v18.18.0
√ yo v5.0.0
√ gulp-cli v3.0.0
× typescript v4.7.4 installed in the project

Additional environment details

No response

@ervingayle ervingayle added the type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs label Nov 8, 2024
@ervingayle
Copy link
Contributor Author

I am also able to submit a PR for those samples that are missing this file

@ervingayle
Copy link
Contributor Author

Hi @hugoabernier . Tagging you to this for guidance.

@hugoabernier
Copy link
Collaborator

While the .yo-rc.json is not necessary, adding it to individual samples would be a welcome contribution!

I'll keep an eye open for future PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:bug-suspected Suspected bug (not working as designed/expected). See type:bug-confirmed for confirmed bugs
Projects
None yet
Development

No branches or pull requests

2 participants