Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid writing LSP Request errors twice to logs #99

Open
DavisVaughan opened this issue Dec 13, 2024 · 0 comments
Open

Avoid writing LSP Request errors twice to logs #99

DavisVaughan opened this issue Dec 13, 2024 · 0 comments

Comments

@DavisVaughan
Copy link
Collaborator

Once is done by our logging system, another is done from the middleware when we return an error.

Rust-analyzer overrides handleFailedRequest to never show the notification to the user as a toast message. We could do this too if we wanted to. https://github.com/rust-lang/rust-analyzer/blob/f50969b23958323ac2094cc1c0fb5881345928f7/editors/code/src/lang_client.ts#L5

(Note that in general this specific case should not even be an LSP error, see #65, but still)

Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant