Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selectize & other 3rd party CSS should be re-compiled for Bootstrap 5 #782

Open
cpsievert opened this issue Oct 24, 2023 · 1 comment · Fixed by #772
Open

Selectize & other 3rd party CSS should be re-compiled for Bootstrap 5 #782

cpsievert opened this issue Oct 24, 2023 · 1 comment · Fixed by #772
Assignees

Comments

@cpsievert
Copy link
Collaborator

cpsievert commented Oct 24, 2023

py-shiny currently copies over CSS (and JS) from (R) shiny (which is pre-compiled with Bootstrap 3 in mind).

In the build script, we do re-compile CSS for ionRangeSlider to target Bootstrap 5 (+ our styling tweaks). We should be doing a similar thing for input_selectize(), input_date(), etc...

@cpsievert cpsievert changed the title shiny.css, selectize, & other 3rd party CSS should be re-compiled for Bootstrap 5 Selectize & other 3rd party CSS should be re-compiled for Bootstrap 5 Oct 24, 2023
@cpsievert
Copy link
Collaborator Author

cpsievert commented Oct 27, 2023

#772 didn't close this issue. Here's a reprex of the problem. The border for input_selectize() doesn't match input_select() because selectize.css hasn't been compiled against bs_theme(preset = "shiny").

from shiny import App, Inputs, Outputs, Session, ui

app_ui = ui.page_fluid(
    ui.input_select("n", "N", choices=["a", "b", "c"]),
    ui.input_selectize("n2", "N2", choices=["a", "b", "c"]),
)

def server(input: Inputs, output: Outputs, session: Session):
    pass

app = App(app_ui, server)
Screenshot 2023-10-27 at 2 26 21 PM

@cpsievert cpsievert reopened this Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants