From 0ee9b3cf084031042654c071b97b3a60853a367c Mon Sep 17 00:00:00 2001 From: GriffinR Date: Tue, 15 Oct 2024 22:17:38 -0400 Subject: [PATCH] Fix event_constants recipe running twice --- map_data_rules.mk | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/map_data_rules.mk b/map_data_rules.mk index 7c26c1f76957..4c255c098b7d 100755 --- a/map_data_rules.mk +++ b/map_data_rules.mk @@ -37,6 +37,9 @@ $(LAYOUTS_OUTDIR)/layouts.inc $(LAYOUTS_OUTDIR)/layouts_table.inc $(INCLUDECONST # Generate files that depends on data that's distributed across the map.json files. # There's a lot of map.json files, so we print an abbreviated output with echo. -$(INCLUDECONSTS_OUTDIR)/map_event_ids.h $(DATA_SRC_SUBDIR)/heal_locations.h: $(MAP_JSONS) +# We're also not using a pattern rule, and we only want this to run once for both targets, +# so we use a separate target 'event_constants'. +$(INCLUDECONSTS_OUTDIR)/map_event_ids.h $(DATA_SRC_SUBDIR)/heal_locations.h: .event_constants ; +.event_constants: $(MAP_JSONS) @$(MAPJSON) event_constants emerald $^ $(INCLUDECONSTS_OUTDIR)/map_event_ids.h $(DATA_SRC_SUBDIR)/heal_locations.h @echo "$(MAPJSON) event_constants emerald $(INCLUDECONSTS_OUTDIR)/map_event_ids.h $(DATA_SRC_SUBDIR)/heal_locations.h"