Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INFRA] Remove legacy-peer-deps=true from .npmrc when possible #2928

Closed
tbouffard opened this issue Oct 16, 2023 · 1 comment · Fixed by #2974
Closed

[INFRA] Remove legacy-peer-deps=true from .npmrc when possible #2928

tbouffard opened this issue Oct 16, 2023 · 1 comment · Fixed by #2974
Assignees
@tbouffard
Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Milestone
0.43.0

Comments

@tbouffard
Copy link
Member

In #2927 (review), I added an extra configuration to make the installation of rollup-plugin-sizes with rollup v4.
As soon as a new version of rollup-plugin-sizes that officially supports rollup v4 is available, we should remove the workaround.

Notes

We already had to do the same task in the past: #2416
@tbouffard tbouffard added the chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...) label Oct 16, 2023
@tbouffard tbouffard modified the milestones: 0.41.1, 0.42.0, 0.43.0 Oct 16, 2023
@tbouffard
Copy link
Member Author

https://github.com/tivac/rollup-plugin-sizes/releases/tag/v1.0.6 now supports rollup@4, so this should be possible to implement this issue.

@tbouffard tbouffard self-assigned this Nov 23, 2023
@tbouffard tbouffard mentioned this issue Nov 23, 2023
Merged
@tbouffard tbouffard linked a pull request Nov 23, 2023 that will close this issue
chore(deps-dev): bump the rollup group with 2 updates #2974
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tbouffard tbouffard

Labels
chore Build, CI/CD or repository tasks (issues/PR maintenance, environments, ...)
Projects
Day to Day Board (bpmn-visualization)
Archived in project
Milestone
0.43.0
Development

Successfully merging a pull request may close this issue.

chore(deps-dev): bump the rollup group with 2 updates process-analytics/bpmn-visualization-js
1 participant
@tbouffard