Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable image area selection for non-Embed widgets #3186

Closed
Tracked by #3185
alundgard opened this issue Oct 10, 2024 · 3 comments · Fixed by #3350
Closed
Tracked by #3185

Enable image area selection for non-Embed widgets #3186

alundgard opened this issue Oct 10, 2024 · 3 comments · Fixed by #3350
Assignees

Comments

@alundgard
Copy link

For widgets that display images statically (i.e., do not afford panning and zooming interactions within an embedded viewer).

  • Item Row
  • Uploaded Item Row
  • Item Grid
  • Item Carousel
  • Item Slideshow

Add an option Select image area to specify the region of interest.
image9
Clicking Select image area opens a modal for the cropping interface. Repurpose the existing cropping interface and controls—currently used for the exhibit masthead and thumbnail images. However, unlike the masthead and thumbnail images, the blue area selector should be freeform rather than constrained to a fixed aspect ratio.
image6

@taylor-steve
Copy link
Contributor

@alundgard and/or @hudajkhan I have a question about how the Item Grid widget should work with this. That widget imposes styling on the image to constrain them to the grid. For example in #3350 if I configure a page as such:
Screenshot 2024-12-16 at 3 22 23 PM
Screenshot 2024-12-16 at 3 22 12 PM

It yields:
Screenshot 2024-12-16 at 3 22 36 PM

Did this come up in discussion around this widget? In general, what are the expectations around widgets like this? E.g., do we keep the current styling or do we need to discuss how to alter the display side of the widget(s) to better reflect what this new feature offers?

@alundgard
Copy link
Author

@taylor-steve@hudajkhan and I discussed this briefly. The Grid widget dynamically applies its own "cropping" and aspect ratio styles, depending on the number of images the creator selects to include in the grid. Creators must select images and order them carefully so that they appear as desired within the grid. I think we can assume the same is true of selecting image areas for this widget: creators should make their selection carefully, so they appear as desired. I would be wary of making changes to the current Grid widget styling, which could negatively affect existing exhibits.

@taylor-steve
Copy link
Contributor

@alundgard That's perfect. I expected as much but I wanted to get it in the written history. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants