Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Help: Deaktivierte Schalter scheinen beim dialog-Tag durch #5484

Closed
deleonio opened this issue Oct 26, 2023 · 7 comments
Closed

📖 Help: Deaktivierte Schalter scheinen beim dialog-Tag durch #5484

deleonio opened this issue Oct 26, 2023 · 7 comments
Assignees
Labels
doc Improvements or additions to documentation good first issue Good for newcomers v1 v2

Comments

@deleonio
Copy link
Contributor

deleonio commented Oct 26, 2023

Wenn man statt der Modal-Komponente den HTML dialog-Tag verwendet, kann es passieren, dass deaktivierte Elemente im Hintergrund durch den Dialog sichtbar sind.

image
@deleonio deleonio added the help wanted Extra attention is needed label Oct 26, 2023
@deleonio
Copy link
Contributor Author

Hier haben wir das nachgestellt: https://stackblitz.com/edit/vitejs-vite-qjbem3?file=src%2FApp.tsx,src%2Fmain.ts

Workaround / Lösung ist: Den Dialog im DOM möglichst am Ende zu verwenden. So scheinen die deaktivierten Elemente nicht mehr durch den Dialog.

@deleonio deleonio added the cop Community of Practices label Oct 26, 2023
@deleonio
Copy link
Contributor Author

deleonio commented Jan 2, 2024

Known Issue:

@deleonio deleonio added the doc Improvements or additions to documentation label Jan 2, 2024
@deleonio deleonio moved this to 📄 Ready in KoliBri Board Jan 2, 2024
@sdvg sdvg changed the title 📖 Help: Deaktiere Schalter scheinen beim dialog-Tag durch 📖 Help: Deaktivierte Schalter scheinen beim dialog-Tag durch Jan 8, 2024
@deleonio deleonio self-assigned this Feb 13, 2024
@deleonio deleonio moved this from 📄 Ready to 🏗 In progress in KoliBri Board Feb 13, 2024
@deleonio deleonio moved this from 🏗 In progress to 📄 Ready in KoliBri Board Feb 13, 2024
@deleonio deleonio removed their assignment Feb 13, 2024
@deleonio deleonio added v2 v1 good first issue Good for newcomers and removed cop Community of Practices answered help wanted Extra attention is needed labels Feb 13, 2024
Schollkolade added a commit that referenced this issue Mar 8, 2024
Signed-off-by: Schollkolade <154211547+Schollkolade@users.noreply.github.com>
@Schollkolade Schollkolade linked a pull request Mar 8, 2024 that will close this issue
6 tasks
@Schollkolade Schollkolade moved this from 📄 Ready to 🏗 In progress in KoliBri Board Mar 8, 2024
@Schollkolade Schollkolade moved this from 🏗 In progress to ✅ Done in KoliBri Board Mar 8, 2024
@deleonio deleonio moved this from ✅ Done to 🔍 Review in KoliBri Board Mar 11, 2024
@deleonio deleonio assigned sdvg and unassigned Schollkolade Mar 12, 2024
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Mar 12, 2024
@sdvg
Copy link
Member

sdvg commented Mar 12, 2024

Ich habe mal ein minimales Beispiel ohne KoliBri gebaut, hier kann ich das Problem nicht reproduzieren: https://codepen.io/sdvg/pen/yLrJYzj

@sdvg
Copy link
Member

sdvg commented Mar 12, 2024

Problemursache: opacity auf deaktivierten Buttons: https://stackoverflow.com/a/11742116

@sdvg
Copy link
Member

sdvg commented Mar 12, 2024

Praktisch ist hier keine Änderung an KoliBri notwendig, es reicht, dem <dialog> einen z-index von mindestens 1 zuzuweisen.
Angepasstes Beispiel: https://stackblitz.com/edit/vitejs-vite-qbm5eb?file=src%2FApp.tsx,package.json

@sdvg sdvg moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 12, 2024
@sdvg
Copy link
Member

sdvg commented Mar 21, 2024

@deleonio Hier gibt es kein PR, weil der Bugfix ausschließlich im Projekt bzw. auf Stackblitz stattfindet. Ist die Lösung so i.O. und können wir das Ticket schließen?

@deleonio
Copy link
Contributor Author

@Chrisdo82 Es muss der z-index am Dialog gesetzt werden.

@github-project-automation github-project-automation bot moved this from 🔍 Review to ✅ Done in KoliBri Board Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation good first issue Good for newcomers v1 v2
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants