Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💡 Hinweis: Custom-Spin sollte einen Beispiel-Hinweis kriegen #6059

Closed
fohi17 opened this issue Feb 13, 2024 · 1 comment · Fixed by #6225
Closed

💡 Hinweis: Custom-Spin sollte einen Beispiel-Hinweis kriegen #6059

fohi17 opened this issue Feb 13, 2024 · 1 comment · Fixed by #6225
Assignees
@Schollkolade
Labels
a11y-retest good first issue Good for newcomers v1 v2

Comments

@fohi17
Copy link

fohi17 commented Feb 13, 2024

Note

  • Ich achte beim Erstellen des Issues darauf, dass ich keine fachlichen und unternehmensinternen Details preisgebe.

Hilfreicher Hinweis

Das Beispiel, dass gerade in der Komponente "Spin Custom" gezeigt wird ist nicht so schön. Es soll wohl nur zeigen, dass custom Designs möglich sind. Das sollte als Text noch dazu, damit keiner denkt das wäre ein gutes Design für eine Ladeanzeige.
@deleonio deleonio moved this to 📄 Ready in KoliBri Board Feb 13, 2024
@deleonio deleonio removed the status in KoliBri Board Feb 13, 2024
@sdvg
Copy link
Member

sdvg commented Mar 14, 2024

Bestehende Beschreibung ergänzen: "Nicht zwingend barrierefrei."

@sdvg sdvg moved this to 📄 Ready in KoliBri Board Mar 14, 2024
Schollkolade added a commit that referenced this issue Mar 15, 2024
@Schollkolade
Überarbeitete Description für Spin Custom #6059
4599e42
@Schollkolade Schollkolade linked a pull request Mar 15, 2024 that will close this issue
Überarbeitete Description für Spin Custom #6059 #6225
Merged
6 tasks
@Schollkolade Schollkolade moved this from 📄 Ready to 🏗 In progress in KoliBri Board Mar 15, 2024
@Schollkolade Schollkolade moved this from 🏗 In progress to 🔍 Review in KoliBri Board Mar 15, 2024
@deleonio deleonio moved this from 🔍 Review to 🏗 In progress in KoliBri Board Mar 19, 2024
Schollkolade added a commit that referenced this issue Mar 22, 2024
@Schollkolade
Überarbeitete Description für Spin Custom #6059
01d2e39
deleonio added a commit that referenced this issue Mar 22, 2024
@deleonio
Überarbeitete Description für Spin Custom #6059 (#6225)
b9b5834
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in KoliBri Board Mar 22, 2024
sdvg added a commit that referenced this issue Mar 25, 2024
@sdvg
Merge branch 'develop' of github.com:public-ui/kolibri into 5239-prog…
50e443e 
…ress-svg

* 'develop' of github.com:public-ui/kolibri: (47 commits)
  Bump contributor-assistant/github-action from 2.3.1 to 2.3.2
  chore: update readme.md
  chore: fix anonymous.js
  chore: release 2.0.10
  fix: lint typing theme
  Update all snapshots
  chore: update deps and lock
  Update custom.tsx
  Überarbeitete Description für Spin Custom #6059
  Update DoD
  CI pipeline: Include test-tag-name-transformer results in uploaded artefacts
  Update all snapshots
  Add message type classnames to kol-input
  Update all snapshots
  Update all snapshots
  Nav: Allow click events on button entries. Setting a click callback overrides the "toggle expansion" functionality.
  Update Readmes and fix random type error
  Remove complex-form Route
  add new ''input-radio/object" route
  Corrected "li" to "ol"
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Schollkolade Schollkolade

Labels
a11y-retest good first issue Good for newcomers v1 v2
Projects
KoliBri Board
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Überarbeitete Description für Spin Custom #6059 public-ui/kolibri
4 participants
@sdvg @deleonio @fohi17 @Schollkolade