Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new review template format - process both reviewers list and eic #173

Closed
lwasser opened this issue Jul 2, 2024 · 4 comments · Fixed by #174
Closed

Support new review template format - process both reviewers list and eic #173

lwasser opened this issue Jul 2, 2024 · 4 comments · Fixed by #174
Labels
help wanted Extra attention is needed

Comments

@lwasser
Copy link
Member

lwasser commented Jul 2, 2024

from @pllim

"About that error, looks like pyOpenSci/software-submission#152 (automata) has format of "Reviewers: X, Y, Z" but other issues have "Reviewer 1: X" followed by "Reviewer 2: Y""

We have made a few updates to our review template.

  1. instead of having reviewer 1: and reviewer 2 as separate entries - we have a reviewers field. this field accepts an array of github usernames. Right now the workflow is failing on automata as it uses the new template! We will want to add a check to see what reviewer format the field is provided with (reviewers vs reviewer x). Then we can process the names accordingly. This might require an alias on the pydantic end of things.
  2. We also added the EiC field - make sure we support ingesting that field into our pydantic model & then the output yaml file.

when this is addressed we can then close #77 as well.

@sneakers-the-rat
Copy link
Contributor

my bad, i saw that the previous style was changed and i just followed the list format, i can do this rn

@lwasser
Copy link
Member Author

lwasser commented Jul 3, 2024

@sneakers-the-rat we will need to update the workflow to properly parse reviewers in both formats -- the legacy format

we do want to support that format of reviewers: @ reviewer1, @ reviewr2, etc because that will allow us to more easily integrate the bot! But our pydantic model right now only supports reviewer_1 and reviewer_2. so i think we need a validator that parses both reviewer_x and reviewers fields. But also when it grabs the data i suspect we need to fix something there as well.

Screenshot 2024-07-02 at 6 47 49 PM

no apologies needed on your end!! i just made the template change a while ago and forgot i needed to open an issue and update things here. i'm going to merge #172 because that will fix the blank packages page issue!! 😆 which is a very special new "feature".

@sneakers-the-rat
Copy link
Contributor

dw i'm refactoring the parser so this is eaasier (and ya handles the multiple formats and gives us room to grow)

@lwasser lwasser changed the title Support new review template format Support new review template format - process both reviewers list and eic Jul 3, 2024
@lwasser
Copy link
Member Author

lwasser commented Jul 3, 2024

thank you so so much. refactor away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
2 participants