show_pdf_page mistake on page rotate

[lynamosa]

Description of the bug

I use combining single page
but all page had been rotate 90 or 270 will be overflow rect
test.pdf
4up.pdf
i try add rotate=90 or 270, it rotate but overflow content too
please fix it

How to reproduce the bug

[code]import pymupdf
#Same error with fitz import
src = pymupdf.open("test.pdf")
doc = pymupdf.open()  # empty output PDF

width, height = pymupdf.paper_size("a4")  # A4 portrait output page format
r = pymupdf.Rect(0, 0, width, height)

# define the 4 rectangles per page
r1 = r / 2  # top left rect
r2 = r1 + (r1.width, 0, r1.width, 0)  # top right
r3 = r1 + (0, r1.height, 0, r1.height)  # bottom left
r4 = pymupdf.Rect(r1.br, r.br)  # bottom right

# put them in a list
r_tab = [r1, r2, r3, r4]

# now copy input pages to output
for spage in src:
    if spage.number % 4 == 0:  # create new output page
        page = doc.new_page(-1,
                      width = width,
                      height = height)
    # insert input page into the correct rectangle
    page.show_pdf_page(r_tab[spage.number % 4],  # select output rect
                      src,  # input document
                      spage.number)  # input page number

# by all means, save new file using garbage collection and compression
doc.save("4up.pdf", garbage=3, deflate=True)
[code]

PyMuPDF version

1.24.7

Operating system

Windows

Python version

3.11

[JorjMcKie]

This is not a bug, but a typical Discussions item. Transferring ...

[JorjMcKie]

Before things get too complicated, you should de-rotate the input pages when necessary.
This problem has been solved multiple times. I have attached a version with the probably simplest solution:

import pymupdf

src = pymupdf.open("test.pdf")
doc = pymupdf.open()  # empty output PDF

width, height = pymupdf.paper_size("a4")  # A4 portrait output page format
r = pymupdf.Rect(0, 0, width, height)

# define the 4 rectangles per page
r1 = r / 2  # top left rect
r2 = r1 + (r1.width, 0, r1.width, 0)  # top right
r3 = r1 + (0, r1.height, 0, r1.height)  # bottom left
r4 = pymupdf.Rect(r1.br, r.br)  # bottom right

# put them in a list
r_tab = [r1, r2, r3, r4]

# now copy input pages to output
for spage in src:
    spage.remove_rotation()  # remove rotation on input page
    if spage.number % 4 == 0:  # create new output page
        page = doc.new_page(-1, width=width, height=height)
    # insert input page into the correct rectangle
    page.show_pdf_page(
        r_tab[spage.number % 4],  # select output rect
        src,  # input document
        spage.number,
    )  # input page number

doc.ez_save("4up-new.pdf")