Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowText Node is no longer displaying text. #364

Open
lord-lethris opened this issue Sep 29, 2024 · 6 comments
Open

ShowText Node is no longer displaying text. #364

lord-lethris opened this issue Sep 29, 2024 · 6 comments

Comments

@lord-lethris
Copy link

lord-lethris commented Sep 29, 2024

Updated ComfyUI, and now the ShowText Node is no longer displaying text.

workflow (23)

It is however passing text though.

workflow (24)

Its just not showing the text in the ShowText Node's Display like it use to anymore.

@Beatboxace
Copy link

Hi,
I've been having the same problem. I investigated and debugged a bit, and here is a few pointers:
If you are using DeepFuze custom node, there seem to be a conflict as stated here
On the frontend side, when ShowText is done receiving input to display, it goes into nodeType.prototype.onExecuted from showText.js. This executes:

onExecuted?.apply(this, arguments);
populate.call(this, message.text);

The first line seems to wrongly trigger their function from DeepFuze's preview_audio.js

nodeType.prototype.onExecuted = function (data) {
    previewAudio(this, data.audio[0], data.audio[1]);
}

Which results in an error (as we aren't trying to preview audio or anything, the data value passed is null).
When such errors occur, I think comfyUI handles it by using a break, which stops the execution, thus not displaying the text through populate.call.

Possible solutions

  • Users having this problem can try uninstalling the DeepFuze custom node, assuming they aren't using it in the same workflow. This did it for me. I think there is a way to declare a conflict somehow, it could be useful to avoid this.
  • Switching the order of calls in the code seems to do it (still result in an error on DeepFuze's end, but after updating the text in ShowText node), these line 44 and 45 from showText.js would become :
	populate.call(this, message.text);
	onExecuted?.apply(this, arguments);

-> Would there be any side effect to switching the order to that? What is the goal of onExecuted?.apply(this, arguments);in ShowText's context?

  • I guess fixing DeepFuze to filter properly what is received on their end, like handling the case where data is null or not usable for their purposes would do it.

Hope it helps!

@lord-lethris
Copy link
Author

That has indeed helped. you are a star Mr @Beatboxace

I hope DeepFuze gets a fix for it then.

DeepFuze has caused a number of issues with users I see, their requirement file uninstalls newer dependencies and replaces them with MUCH older ones.

Even me, personally, I had to re-install ONNX, Torch and XFormers after DeepFuze ballsed them up.

Or... We just stop using DeepFuze :(

@Yanquansu
Copy link

I have same issue even I didn't installed the DeepFuze

@Xenodimensional
Copy link

I have this same issue and don't have DeepFuze installed. I hope the dev can fix it. Does anyone know of any other nodes that have the same functionality?

@Yanquansu
Copy link

Yanquansu commented Nov 15, 2024 via email

@Xenodimensional
Copy link

Please Pythongosssss, a lot of people, workflows and nodes depend on this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants