Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync will break due to old set-env API -> upgrade git credentials GH actions from v1 to v2 #231

Open
Zethson opened this issue Nov 18, 2020 · 2 comments · Fixed by #232
Open

Sync will break due to old set-env API -> upgrade git credentials GH actions from v1 to v2 #231

Zethson opened this issue Nov 18, 2020 · 2 comments · Fixed by #232
Labels
bug Something isn't working major

Comments

@Zethson
Copy link
Collaborator

Zethson commented Nov 18, 2020

Hi,

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

set-env is already disabled and sync is broken.

Modify v1 to v2

https://github.com/qbicsoftware/qube-cli/blob/master/qube/create/templates/common_files/%7B%7B%20cookiecutter.commonName%20%7D%7D/.github/workflows/sync_project.yml

- uses: oleksiyrudenko/gha-git-credentials@v1

->

- uses: oleksiyrudenko/gha-git-credentials@v2

Ensure that this is reflected in all already existing projects.

Cheers
Lukas
@Zethson Zethson added bug Something isn't working major labels Nov 18, 2020
@KochTobi
Copy link
Contributor

Thanks for creating the issue @Zethson 👍

@KochTobi KochTobi assigned KochTobi and unassigned KochTobi Nov 19, 2020
@KochTobi KochTobi mentioned this issue Nov 19, 2020
Merged
@KochTobi KochTobi linked a pull request Nov 19, 2020 that will close this issue
Increase oleksiyrudenko/gha-git-credentials version #232
Merged
KochTobi added a commit that referenced this issue Nov 19, 2020
@KochTobi
Fix #231
50ca53a 
Changes oleksiyrudenko/gha-git-credentials@v1 to oleksiyrudenko/gha-git-credentials@v2
KochTobi added a commit to qbicsoftware/data-model-lib that referenced this issue Nov 19, 2020
@KochTobi
Increase gha-git-credentials version
abcc71c 
See qbicsoftware-archive/qube-cli#231
@KochTobi KochTobi mentioned this issue Nov 19, 2020
Merged
KochTobi added a commit to qbicsoftware/data-model-lib that referenced this issue Nov 19, 2020
@KochTobi
Increase gha-git-credentials version (#108)
fb76c52 
See qbicsoftware-archive/qube-cli#231
@Zethson
Copy link
Collaborator Author

Zethson commented Nov 19, 2020 •
edited
Loading

The sync workflow in data-model-lib is old aka out of sync.

name: Sync qube project

on: [push]

should be

name: Sync qube project

on:
  schedule:
    - cron: '*/10 * * * *'
  workflow_dispatch:

tbh to fix it properly you should merge into master once (you don't have to release!) and copy the workflow from e.g. q-offer-2 .

Sync compares against the master branch currently (see #227), which may generate a false negative when syncing here.

#227 is also a trivial fix :)

KochTobi added a commit to qbicsoftware/data-model-lib that referenced this issue Nov 23, 2020
@Steffengreiner @KochTobi
@sven1103 @JohnnyQ5 @jenniferboedker
Release/1.12.0 (#109)
5c903a0 
* Bump development version to 1.12.0-SNAPSHOT

* Provide EnumFactory (#63)

This PR introduces an abstract enum factory class and
an example AcademicTitleFactory implementation.

With this, we are able to create enums from values in the future.

* Configure workflow for Nexus deployment

* Correct settings

* Rename job for nexus deployment

* Setup Github actions report generation

* Load conda env

* Set Workspace properly

* Use conda GA

* Load conda env properly

* Correct path to report python file

* Provide maven cache

* Load maven cache

* Remove python GA

* Correct report generation

* setup cache

* Remove deployment to Github Maven repo

* Load conda properly

* Correct job names

* Use correct branch name

* Install git

* Provide traceback

* Use native python over conda

* Print tmp perms

* Remove report generation

* More debugging

* Remove workspace path info

* Try to fetch error messages

* Remove check

* Print it

* Try Johnny Q5 power

* Configure git

* Set git global

* Beautify config

* Remove travis

* Introduce new GA for releases

* Initial template commit

* Template merge (#64)

Introduces the skeleton structure that originates from QUBE.

With this, we connect the TEMPLATE commit history and enable future
synchronisation via QUBE, once new templates are released.

* Remove sync workflow from TEMPLATE branch

* Removes travis support

* Add equals and hashValue methods for each dto class (#65)

This PR adds equals() and hashValue() methods for each dto class.

* Omit pypi cache for qube installation

* Increase sync level to patch

* Use token when checkout code

* Implement AffiliationCategoryFactory (#66)

* Implement AffiliationCategoryFactory

* Update Changelog

Co-authored-by: Sven F <sven.fillinger@mailbox.org>

* Enable verbose qube execution during syncing

* qube sync

* Correct repo info

* Set correct user

* Update qube config

* Force name

* Fix project name

* Fix project name again

* Fix no hyphen slug

* Fix yaml

* Update CL

* Important qube template update 1.0.2 released! (#69)

This PR syncs the data model lib with the latest changes in the Qube template.

Co-authored-by: Sven F <sven.fillinger@mailbox.org>

* Remove empty example package (#70)

* Initial template commit

* Remove old workflow

* qube sync

* Complete POM again

* Add jitpack.io repository

* Bump version from 1.0.0-SNAPSHOT to 1.0.0

* Bump version from 1.0.0 to 1.12.0-SNAPSHOT

* qube sync

* Sync versions with Qube

* qube sync

* qube sync

* Feature/affiliation fix (#77)

* Add toString() to Affiliation

* Remove unnecessary new lines

* Fix RST header

Co-authored-by: Sven Fillinger <sven.fillinger@qbic.uni-tuebingen.de>

* Add identifiers for TOMATO (#67)

* create identifier classes, add id properties and method for creating identifiers

Co-authored-by: Tobias Koch <tobias.koch@qbic.uni-tuebingen.de>

* Update offer related classes (#80)

* introduce a person to be able to introduce persons that are not customers
* resolve java style issues and wrong return types

Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>

* Rename Quotation to Offer and QuotationId to OfferId. Additionally, Change String Type of OfferId from "Q" to "O"

* Refactor/offer constructor (#83)

* Add Additional minimalist Constructors to Offer DTO and provide Test to
check for offer generation with each constructor

* Refactor Offer and OfferSpec to follow Builder pattern akin to the Affiliation DTO

* Remove toString Method from Offer DTO

Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>

* Restore old Offer accounting object and move dto into dto directory

* change items list in Offer DTO to unmodifiable

* Fix getItems getter

Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
Co-authored-by: Tobias Koch <tobias.koch@qbic.uni-tuebingen.de>

* Add customer affiliation to offer DTO (#84)

Adds the selected affiliation of a customer to the offer DTO

* Refactor/cost estimate and product item (#87)

* Update CostEstimate so it matches the properties of the Offer DTO, deprecate old Person DTO and remove computeTotalCost method from ProductItem

* Move CostEstimate Class to Builder Pattern so it matches the Offer Class and add a description to OfferClass Test

* Add Testing for ProductItem and Costestimate DTO

* Implement Project Manager as an extension of the abstract Person Class and remove personType from the Person and Customer Class

* Refactor Person Class to Project Manager Class cherry-picked from Feature/ProjectManager Branch

* Revert projectManager back to Customer in CustomerSpec

* Add product DTOs (#91)

This PR introduces classes for several QBiC service products.

* Feature/project manager (#86)

This PR introduces the ProjectManager DTO as an extension of the abstract Person class.
It's intended to store the information of a project manager whose e.g. associated with an Offer.
Additionally, it removes the redundant person type property from the Person class and its implementation in the customer DTO.

Co-authored-by: Steffengreiner <Steffen.Greiner@gmx.de>
Co-authored-by: Sven F <sven.fillinger@qbic.uni-tuebingen.de>

* Clean Up commented code from Address DTO and replace null values with (#82)

* Clean Up commented code from Address DTO and replace null values with
default values for each property with testing.

* Create Address DTO with Builder Pattern and Testing, and set old Address to deprecated until we figure out how and where it is used

* Update Readme with current DTO ER diagram and add description and linkage to README.md (#92)

* Update Changelog with new changes to DTOs (#90)

* Update Changelog with DTO changes

* Fix Typos and mention inclusion of description and diagram of offer related DTOs in Changelog

* Specify DTOs with a path to the source root

* Provide more unit enums (#93)

This PR adds two more unit enums for the service products.

The new enums are "Sample" and "Dataset".

* Fix/modifier scope (#94)

Enables the Groovy Compiler to auto-generate getters for the product classes.

* Add product unit enum factory (#95)

This PR adds a product unit factory, that delivers a matching product unit enum for a given String value.

* Update CHANGELOG.rst

* Refactor Person Field eMailAddress to emailAdress (#96)

* Remove "Unknown" member from Affiliation Category, Add Testing and updates the DTO diagram accordingly (#99)

* Remove "Unknown" member from Affiliation Category, Add Testing and update DTO diagram accordingly

* Remove unnecessary test

Co-authored-by: jnnfr <jennifer.boedker@qbic.uni-tuebingen.de>

Co-authored-by: jnnfr <jennifer.boedker@qbic.uni-tuebingen.de>

* Add correct Product class to ProductItem (#98)

* exchange product type

* add deprecated status to old product class

* remove description, name from ProductItem, fix tests

Co-authored-by: Steffengreiner <Steffen.Greiner@gmx.de>

* Fix/qube update (#102)

A new release of the main template in qube has just been released.
This pull-request attempts to apply the relevant updates to this Project.
It can be seen as a replacement PR for #78

Once complete, make a new minor release of your Project.

For more information on the actual changes, read the latest qube changelog.

Co-authored-by: JohnnyQ5 <support@qbic.zendesk.com>

* Restore .github/dependabot.yml

* Increase gha-git-credentials version (#108)

See qbicsoftware-archive/qube-cli#231

* Fix/#105 (#107)

This addresses #105 
* Add missing tests for equality and hashCode

* Use super fields for hashCode and equals in Customer

* Add EqualsAndHashCode annotation to ProjectManager

* Refactor Offer DTO fields into required and optional parameters (#97)

* Refactor Offer DTO fields into required and optional parameters

* Slim required parameters for Offer DTO down to basic necessities

* Remove star from the version number

* Slim Offer DTO To smallest constructor possible and introduce Costestimate DTO  with same builder pattern as the offer DTO

* Change Offer & CostEstimate Builder according to Feedback

* Refactor old accounting classes into DTOs.  (#101)

* Refactor old accounting classes into DTOs. Deprecate old accounting CostEstimate and replace it with a DTO akin to the offer DTO. Update DTO description and tests

* Set version of Offer Class correctly

* Add @EqualsAndHashCode back to CostEstimate

* Replace Offer in CostestimateSpec with CostEstimate

* Bump version from 1.12.0-SNAPSHOT to 1.12.0

* Move deprecated entries to a deprecated section of the changelog

Co-authored-by: Tobias Koch <tobias.koch@qbic.uni-tuebingen.de>
Co-authored-by: Tobias Koch <KochTobi@users.noreply.github.com>
Co-authored-by: Sven Fillinger <sven.fillinger@qbic.uni-tuebingen.de>
Co-authored-by: Sven F <sven.fillinger@mailbox.org>
Co-authored-by: JohnnyQ5 <support@qbic.zendesk.com>
Co-authored-by: Johnny Q5 <50356506+JohnnyQ5@users.noreply.github.com>
Co-authored-by: jnnfr <jennifer.boedker@qbic.uni-tuebingen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase oleksiyrudenko/gha-git-credentials version qbicsoftware-archive/qube-cli
2 participants
@KochTobi @Zethson