Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON schema is broken. #24685

Open
uk-taniyama opened this issue Dec 7, 2024 · 2 comments
Open

JSON schema is broken. #24685

uk-taniyama opened this issue Dec 7, 2024 · 2 comments

Comments

@uk-taniyama
Copy link

"," is missing.

"type": "object",
"propertyNames": {"enum": ["x", "y", "z", "rx", "ry", "rz"]}
"additionalProperties": {
"oneOf": [

There is an extra ",".

"userspace_version": {
"type": "string",
},
}


@fauxpark
Copy link
Member

fauxpark commented Dec 7, 2024

These are currently read as HJSON, so it is technically not an issue at the moment. There is an open PR which fixes the syntax issues as part of its changeset: #24594

@Buckwich
Copy link
Contributor

Buckwich commented Dec 8, 2024

If you want to use json-schemas that follow the json and json-schema specification I have extracted them in a seperate Repo until my PR #24594 is merged: https://github.com/kcf-hub/qmk-types

With those schemas, ref resolution is also adjusted so that tools like vs-code can directly resolve them by relative paths

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants