Sulfur ore generation mechanics

[andreblanke]

I'm trying to port the classic sulfur ore generation mechanics and would like to get some feedback on the generation mechanics.

The 1.12 version of Railcraft would try to generate sulfure ore in mountainous biomes (GeneratorSulfur.java#L30-L33) with 90 generation attempts between Y levels 6 to 15 (GeneratorSulfur.java#L37-L42) in the vicinity of lava (WorldGenSulfur.java#L31-L49).

When porting the same logic only adjusted for the new world height, two issues arise:

• mountainous biomes are now likely to generate the deep dark biome at lower Y levels which would prevent sulfur from generating and
• regular, non-deepslate sulfur ore would become unobtainable and thus redundant.

Issue 1 is easily addressed by allowing sulfur to spawn in the deep dark. Issue 2 is a bit harder to resolve. My first idea for a solution would be to have a few sulfur generation attempts (say 1-3) in mountainous biomes that scan the Y levels 0 to 64 in search for lava (likely a naturally generated lava lake, 1/9 chance for each chunk) and generates a deposit there. The upper sulfur deposits would be rarer than the lower ones, but could indicate to a player that it generates around lava.

[Edivad99]

The sulfur generation, as it is implemented now, takes inspiration from mekanism, in this pr I explain how it is generated