From c078afd498cedba61f03911f728709c31ee54680 Mon Sep 17 00:00:00 2001 From: MFransen69 <39826971+MFransen69@users.noreply.github.com> Date: Mon, 23 Sep 2024 18:21:52 +0200 Subject: [PATCH 1/3] [IDolby] Improve backwards compatibility (#380) --- interfaces/IDolby.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/interfaces/IDolby.h b/interfaces/IDolby.h index fc94ea00..ebbd7fab 100644 --- a/interfaces/IDolby.h +++ b/interfaces/IDolby.h @@ -50,7 +50,7 @@ namespace Exchange { PASSTHRU, DOLBYDIGITAL, DOLBYDIGITALPLUS, - SOUNDMODE_AUTO /* @text:Auto */ + SOUNDMODE_AUTO }; // @event @uncompliant:extended From 4882b2c0e4883c3096d7e64a2a6c265f9bde14a7 Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Mon, 14 Oct 2024 12:27:34 +0200 Subject: [PATCH 2/3] [Actions] Fix Actions after the update of GitHub hosted runners (#388) * Make sure to use the development templates for testing the changes * Make sure to install jsonref in venv, improve the 32-bit libs instalation * Activate the virtual environment for the building job * Add a new way to specify the branch of a build template to speed up the development in Actions * Try without the nested conditions * Try to include no white space in the uses branch specify * See try an approach with open source dynamic uses action * Let's see why it fails, print the output of the previous job * The job ID has to be unique, to the output has to be processed later to be swapped for master if empty * Oops, wrong syntax, fix it and rerun * Apparently we have to pass github.sha instead of just a branch name * Try a different approach * Try with a static name * There is no simple way to use dynamic variable for using apart from changing the whole actions structure in each repo * Get ready for the PR --- .github/workflows/Build ThunderInterfaces on Linux.yml | 2 +- .github/workflows/Linux build template.yml | 7 +++++-- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/Build ThunderInterfaces on Linux.yml b/.github/workflows/Build ThunderInterfaces on Linux.yml index e9bf6142..657c4d51 100644 --- a/.github/workflows/Build ThunderInterfaces on Linux.yml +++ b/.github/workflows/Build ThunderInterfaces on Linux.yml @@ -13,7 +13,7 @@ jobs: ThunderInterfaces: needs: Thunder - uses: rdkcentral/ThunderInterfaces/.github/workflows/Linux build template.yml@master + uses: rdkcentral/ThunderInterfaces/.github/workflows/Linux build template.yml@development/actions-gcc-13 # change back to master ThunderClientLibraries: needs: ThunderInterfaces diff --git a/.github/workflows/Linux build template.yml b/.github/workflows/Linux build template.yml index 64124112..7c9a9d9e 100644 --- a/.github/workflows/Linux build template.yml +++ b/.github/workflows/Linux build template.yml @@ -28,8 +28,10 @@ jobs: echo "deb http://archive.ubuntu.com/ubuntu/ jammy-updates main universe restricted multiverse" | sudo tee -a /etc/apt/sources.list sudo dpkg --add-architecture i386 sudo apt-get update - sudo apt install python3-pip build-essential cmake ninja-build libusb-1.0-0-dev zlib1g-dev zlib1g-dev:i386 libssl-dev gcc-11-multilib g++-11-multilib - sudo pip install jsonref + sudo apt install python3-pip build-essential cmake ninja-build libusb-1.0-0-dev ${{matrix.architecture == '32' && 'zlib1g-dev:i386 libssl-dev:i386 gcc-13-multilib g++-13-multilib' || 'zlib1g-dev libssl-dev'}} + python3 -m venv venv + source venv/bin/activate + pip install jsonref - name: Download artifacts uses: actions/download-artifact@v4 @@ -70,6 +72,7 @@ jobs: # ----- Building & uploading ----- - name: Build ThunderInterfaces run: | + source venv/bin/activate cmake -G Ninja -S ThunderInterfaces -B ${{matrix.build_type}}/build/ThunderInterfaces \ -DCMAKE_CXX_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \ -DCMAKE_C_FLAGS="-Wall -Wextra -Wpedantic -Werror -m${{matrix.architecture}}" \ From 9bb995b1a967a4ae49de66080f44618dcb27f89e Mon Sep 17 00:00:00 2001 From: Mateusz Daniluk <121170681+VeithMetro@users.noreply.github.com> Date: Mon, 14 Oct 2024 12:59:49 +0200 Subject: [PATCH 3/3] [Actions] Use the template from master and explicitly state the Ubuntu version (#389) * Explicitly state the ubuntu version * Use the template from master as it was merged --- .github/workflows/Build ThunderInterfaces on Linux.yml | 2 +- .github/workflows/Linux build template.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/Build ThunderInterfaces on Linux.yml b/.github/workflows/Build ThunderInterfaces on Linux.yml index 657c4d51..e9bf6142 100644 --- a/.github/workflows/Build ThunderInterfaces on Linux.yml +++ b/.github/workflows/Build ThunderInterfaces on Linux.yml @@ -13,7 +13,7 @@ jobs: ThunderInterfaces: needs: Thunder - uses: rdkcentral/ThunderInterfaces/.github/workflows/Linux build template.yml@development/actions-gcc-13 # change back to master + uses: rdkcentral/ThunderInterfaces/.github/workflows/Linux build template.yml@master ThunderClientLibraries: needs: ThunderInterfaces diff --git a/.github/workflows/Linux build template.yml b/.github/workflows/Linux build template.yml index 7c9a9d9e..9f3c0ebd 100644 --- a/.github/workflows/Linux build template.yml +++ b/.github/workflows/Linux build template.yml @@ -6,7 +6,7 @@ on: jobs: ThunderInterfaces: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 strategy: matrix: