-
Notifications
You must be signed in to change notification settings - Fork 652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for changing the default compression level when enabling server response compression #3244
Comments
@juliojgd Are you interested in providing a PR? Which Reactor Netty version should enable this feature (1.1.x or 1.2.x)? |
@violetagg we are using Spring Boot 3.2.x so I guess we'd need 1.1.x. I'll try to provide a PR. The source branch to checkout for the changes would be https://github.com/reactor/reactor-netty/tree/1.1.x , right? Thanks in advance |
yes |
@violetagg |
@raccoonback Yes sure, go for it. Please follow the contribution guide https://github.com/reactor/.github/blob/main/CONTRIBUTING.md |
- gzip: only the range 0 to 9 is allowed - deflate: only the range 0 to 9 is allowed - zstd: only the range -7 to 22 is allowed brotli and snappy compression are supported by default. fix: reactor#3244
- gzip: only the range 0 to 9 is allowed - deflate: only the range 0 to 9 is allowed - zstd: only the range -7 to 22 is allowed brotli and snappy compression are supported by default. fix: reactor#3244
Motivation
In the server compression related documentation the only configurable parameters are enabled (boolean) and minimum size for a payload to be compressed (int).
There is no method in Reactor Netty HttpServer that allows to set the compression level (int) that is effectively available in Netty's HttpContentCompressor class but it's not available in the default SimpleCompressionHandler
It cannot be set in the Reactor Netty HttpServerResponse either.
Desired solution
To add a configurable property (maybe named "compression-level" or "gzip-compression-level") to allow changing the default compression level (6 - gzip) to any other compression level that the developer needs to set.
The text was updated successfully, but these errors were encountered: