Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Netty does not provide errorLog just accesLog #3257

Open
paulbors opened this issue May 22, 2024 · 1 comment
Open

Netty does not provide errorLog just accesLog #3257

paulbors opened this issue May 22, 2024 · 1 comment
Labels
help wanted We need contributions on this type/enhancement A general enhancement

Comments

@paulbors
Copy link

As a system administrator, I would like to see errorLogs in Netty web server similar to those of Apache HTTPD when the client socket is closed and we receive no accessLog.

Motivation

Netty web server does not log web server errors for requests that do not complete (ie: connection terminated is not captured in accessLog which should really be following Apache HTTPD errorLog).

Desired solution

A new ChannelDuplexHandler is added similar to BaseAccessLogHandler and its counterparts but for logging the web server access errors only.

Considered alternatives

One could increase the logs to trace to follow the channel termination exception log events, but that is too verbose for a production environment.

Additional context

Implement a similar errorLogs as those of Apache HTTPD:
https://httpd.apache.org/docs/2.4/logs.html#page-header

@paulbors paulbors added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels May 22, 2024
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label May 23, 2024
@violetagg
Copy link
Member

@paulbors Are you interested in providing a PR? Which Reactor Netty version should enable this feature (1.1.x or 1.2.x)?

@violetagg violetagg added the help wanted We need contributions on this label Jun 3, 2024
@violetagg violetagg added this to the General Backlog milestone Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need contributions on this type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants