Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose activeStreams and potentially pendingStreams for use in ConnectionPoolMetrics in MeterRegistrar #3344

Open
FlattestWhite opened this issue Jul 10, 2024 · 3 comments
Labels
help wanted We need contributions on this type/enhancement A general enhancement

Comments

@FlattestWhite
Copy link

We use our own metrics vendor and don't use micrometer. To instrument the httpclient, we have an implementation of MeterRegistrar. There's currently no way to get access to activeStreams in ConnectionPoolMetrics. The provided micrometer metrics internally cast to an Http2Pool before calling its activeStreams method.

Motivation

To work around this, we have to keep a count of concurrent requests through a counter (increment and decrement) and report that. Would prefer to have it come through in ConnectionPoolMetrics

Desired solution

Considered alternatives

Additional context

@FlattestWhite FlattestWhite added status/need-triage A new issue that still need to be evaluated as a whole type/enhancement A general enhancement labels Jul 10, 2024
@violetagg violetagg self-assigned this Jul 10, 2024
@violetagg violetagg removed the status/need-triage A new issue that still need to be evaluated as a whole label Jul 10, 2024
@violetagg
Copy link
Member

@FlattestWhite Would you like to create a PR? You didn't mention Reactor Netty version.

@FlattestWhite
Copy link
Author

Thanks @violetagg reactor netty version is 1.1.21. Just wanted to confirm that activeStreams metric isn't available through existing interface. If that's the case, I'll look to create a PR sometime for it.

@violetagg
Copy link
Member

violetagg commented Jul 11, 2024

Just wanted to confirm that activeStreams metric isn't available through existing interface. If that's the case, I'll look to create a PR sometime for it.

Yeah it is not exposed there as this is reactor-netty-core and we cannot add http related information. I think that we can provide something in reactor-netty-http that adds this information.

@violetagg violetagg removed their assignment Jul 16, 2024
@violetagg violetagg added this to the General Backlog milestone Jul 17, 2024
@violetagg violetagg added the help wanted We need contributions on this label Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted We need contributions on this type/enhancement A general enhancement
Projects
None yet
Development

No branches or pull requests

2 participants