Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The rpmautospec preprocessing may fail #71

Open
praiskup opened this issue Nov 22, 2024 · 1 comment
Open

The rpmautospec preprocessing may fail #71

praiskup opened this issue Nov 22, 2024 · 1 comment

Comments

@praiskup
Copy link
Member

The while rpmautospec_core.specfile_uses_rpmautospec is supposed to always
work, the rpmautospec.process_distgit may fail to parse the specfile.

There's the option error_on_unparseable_spec that we can set to False . But
we should first fully understand the consequences.
praiskup added a commit to praiskup/dist-git that referenced this issue Nov 22, 2024
@praiskup
Add a git-snapshot (tarball) generator
30b4554 
The src.rpm is distribution-specific format;  the `rpmbuild -bs` doesn't
necessarily generate the same output SRC.RPM if run on different
distributions.  The `snapshot` tarball is though generated in a
distribution-agnostic way.

Note that this tarball generator still requires specfile parsing by RPM,
and it may fail easily, see release-engineering#71 for more info.
@praiskup praiskup mentioned this issue Nov 22, 2024
Open
praiskup added a commit to praiskup/dist-git that referenced this issue Nov 24, 2024
@praiskup
Add a git-snapshot (tarball) generator
7dfc65f 
The src.rpm is distribution-specific format;  the `rpmbuild -bs` doesn't
necessarily generate the same output SRC.RPM if run on different
distributions.  The `snapshot` tarball is though generated in a
distribution-agnostic way.

Note that this tarball generator still requires specfile parsing by RPM,
and it may fail easily, see release-engineering#71 for more info.
@praiskup
Copy link
Member Author

Tested with jello.spec from Rawhide, and c10s variant fails to generate the version-release in changelog:

55c55
< * Fri Nov 01 2024 Benjamin A. Beasley <code@musicinmybrain.net> - 1.6.0-12
---
> * Fri Nov 01 2024 Benjamin A. Beasley <code@musicinmybrain.net>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@praiskup